Repository navigation
Conversation
proxy.certificate_check only relaxed TLS for the origin wording-wise, but EdgeZero verifies every outbound HTTPS request regardless. Update the error, warning, settings docs, guides and example config to say so, and test that pull sync sends the same request and stores the partner ID whether the check is on or off. Closes #1556
Pull sync: the base deletes core ec/pull_sync.rs, so the merge takes the deletion. This pull request changed only that file's tests, adding the differential certificate-check test, so the test moves to where pull sync now sends: the Fastly post-delivery work, which builds the after-response pull-sync provider from the settings and sends its lookup through OutboundLookupTransport. The ported test runs post-delivery work with certificate_check true and false, each against its own fresh live row in the local identity store, and asserts the same method, URL, headers and body, the lookup transport's timeout, buffered cap, decoding and cache policy, and that both runs store the partner UID. The pull-sync test helpers take the EC ID so this test never writes the row the other pull-sync tests share. Docs: the certificate_check guide entry names identity providers, pull sync among them, since pull sync is one in the base. The config message, settings doc comment, guides and example config apply this pull request's wording unchanged.
|
For the identity integration chain (#1608), this PR now stacks on #1489, which deletes This PR's only change in Checked locally at |
Summary
proxy.certificate_check = falseno longer relaxes anything, but the error, warning, settings doc comment, guides and example config still said it relaxed the origin.Changes
crates/trusted-server-core/src/ec/pull_sync.rsdispatch_pull_sync_ignores_relaxed_certificate_checkand apull_oncehelpercrates/trusted-server-core/src/config.rscertificate_checkerror and warningcrates/trusted-server-core/src/settings.rscertificate_checkdoc commentdocs/guide/configuration.md,docs/guide/edgezero.md,docs/guide/error-reference.mdtrusted-server.example.tomldocs/superpowers/specs/2026-11-16-identity-backend-certificate-checks-design.mddocs/superpowers/plans/2026-11-16-identity-backend-certificate-checks.mdCloses
Closes #1556
Spec
Not a feature. The design notes are in
docs/superpowers/specs/2026-11-16-identity-backend-certificate-checks-design.md.Test plan
cargo test-fastly: left to CI. The local Viceroy is older than the pinned 0.21.0cargo test-axum,cargo test-cloudflare,cargo test-spincargo clippy-fastly && cargo clippy-axum && cargo clippy-cloudflare && cargo clippy-cloudflare-wasm && cargo clippy-spin-native && cargo clippy-spin-wasmcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcertificate_checkconfig tests pass natively. A mutation check broke the test both ways: making the relaxed setting change the URL, and adding a header.ts dev lint domains --changed-vs origin/mainis clean.Checklist
unwrap()in production code — useexpect("should ...")logmacros (notprintln!)