Repository navigation
Reconciled follow-up above PR 1506 - #1605
Closed
ChristianPavilonis wants to merge 4 commits into
Closed
ChristianPavilonis wants to merge 4 commits into
ChristianPavilonis wants to merge 4 commits into
Conversation
Carry the behavior merged in #1516 at1810c763 without restoring the retired transport abstraction. Keep optimized requests and ordinary raw GET/unsigned HEAD caching unchanged.
ChristianPavilonis
marked this pull request as ready for review
November 13, 2026 18:45
aram356
added a commit
that referenced
this pull request
Nov 15, 2026
Pins the six EdgeZero crates to 10166628, a commit of EdgeZero's rc/identity integration branch. It carries PR 275's head e9ffaa8f, which is 5c32ae61 with EdgeZero main merged in, plus the PRs stacked on PR 275 (EdgeZero 499, 460, 406, 407, 409, 414, 422 and 439) and the JA4 request interface (EdgeZero 469). - EdgeZero 409 removes Forwarded and X-Forwarded-* fields on Axum before routing. The Axum router now records the authenticated forwarder decision in EdgeZero's received-head preparer, which EdgeZero 499 restores and which runs before that removal. The preparer and its two tests come from 3da80af in #1605. - EdgeZero 460 adds cache tags to OutboundCachePolicy, so the type is no longer Copy. Test code clones it, and ExpectedTransport drops Copy. - EdgeZero's workspace pins getrandom to exactly 0.4.2, so the lockfile moves from 0.4.3 to 0.4.2.
This was referenced Nov 15, 2026
Collaborator
|
Closing so that #1506 is the one source of the Axum forwarder change. #1506 at #1506 does not carry the rest of this PR. None of it is needed for the forwarder:
The first three fix main's own test jobs, so a small PR against main fits them best. The raw-control cache test can go onto #1506 or follow it. |
4 tasks
aram356
added a commit
that referenced
this pull request
Nov 19, 2026
The base is #1623's head 78e1f2f, which carries #1612 and #1506's repin of EdgeZero to rc/identity 9d02d7b3. The tree is the base plus this pull request's own changes against its previous base branch. The cutover, the EdgeZero pin and the closed #1605 reconciliation commits that this branch carried come from the base: EdgeZero stays pinned to rc/identity 9d02d7b3 by rev, and the RC tag pin, its Cargo.lock, the #1605 changelog lines, its S3 direct-client patch, its Chrome version pin, its cache harness target-root change, its browser-collector poll fixture and its boxed pre-dispatch test helper are dropped in favor of the base. Axum startup: main runs EdgeZero's run_production_app_with_initializer with the native prepared-store initializer. EdgeZero installs the logger at EDGEZERO__LOGGING__LEVEL as it does on the base, so the adapter's SimpleLogger, its RUST_LOG parsing and its owns_logging override are not revived, and the parse_log_level tests go with them. EdgeZero validates the hosting settings before it installs that logger, so a fatal startup error that finds no logger goes to standard error instead of being dropped, as it was visible before. Axum app: the base's shared identity app, its local identify and batch-sync answers and its enabled-provider rejection stay as they are. The router built by the initializer goes through routes_with_settings, so the production path builds the same IdentityApp and rejects enabled providers the same way. Hooks::routes returns the empty pre-initialization router, Hooks::stores declares the config and secret stores, and every router carries an empty native store snapshot in state. Axum platform: the environment-backed config and secret stores are removed and request services read the immutable prepared snapshots. Tests and harnesses: the route startup test, the integration and EOF harnesses and the smoke script use the prepared local config map and EDGEZERO__SECRETS__ values. The startup, native acceptance and smoke processes set EDGEZERO__LOGGING__LEVEL in place of RUST_LOG, and the provider script drops its unused RUST_LOG value. Docs: the README, the Axum guide and the native RC guide describe the production runner, its fatal invalid host, port and log level values, and the workspace EdgeZero pin 9d02d7b3 in place of the RC tag. Cargo.lock: the base lock plus the 29 packages that the native AWS provider features add, at the same versions as this pull request's own lock.
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh the owned follow-up above #1506 at
57d7c6ad8db43601ef31c1e1d1615e6dd2aa6a6awithout changing Aram's branch or replaying the foundation.v0.0.12-rc-axum.202611.2at4407d941, retaining the deliberate resolved lock and non-Copy/boxed-response caller adaptations.The previous owned candidate and the complete new author history remain ancestors through an ordinary merge. The feature PRs retain their separate startup/Geo/HTTP/EC/consent/storage/image/wrapper/reference boundaries.
Qualification
At owned follow-up
1174c6d6d28df00217d99ff576dc2001ff8fe925, all 161 proxy cases, strict Core lint, native adapter tests, actual CLI proxy cases and docs checks pass. The refreshed combined RC passes 3,447 Core cases with 2 ignored, 114 native-adapter cases with 7 ignored, and 963 CLI cases with 29 ignored. Target-matched native/WASM adapter, strict lint, docs/guard and actual deadline/EOF/trace/cache checks also pass. Exact source, commands, counts, ignored cases, reused fingerprints and residuals are in the local refresh report.JS/consent, six Chrome collector cases, direct DynamoDB Local, wrapper entrypoint and Terraform mock results are reused only with documented unchanged relevant inputs. They are not relabeled as new executions. The new local untagged source image and Agent/Moto proof belong to the refreshed #1539 candidate, not a new RC release.
The initial helper Clippy failure and boundary-check diff-prefix mismatch remain recorded with corrected separate receipts. Prior baseline reds and failed invocations remain input-specific historical evidence. No assertion, security policy, deadline or build-integrity check was weakened.
No fresh hosted/macOS, new RC image, fresh digest-backed wrapper image, external browser/framework or live AWS/publisher/CMP qualification is claimed. Ignored and unexecuted cases are not passes.
Ownership
Draft dependent review above #1506. Aram's TS #1506 and EdgeZero #275 remain read-only. Existing immutable tags are unchanged; no release, main merge, registry publication, deployment or live cloud operation is included. EdgeZero #499 cleanup remains separate. Source PRs #1498/#1557, closed #1545 and unrelated #1527 are not republished or duplicated.
Refs #1506, #1516.
Published snapshot; newer upstream integration pending
Published deliberately for review from the qualified #1506 checkpoint
57d7c6ad8db43601ef31c1e1d1615e6dd2aa6a6a. At publication the moving author branch was at628474ec4a8cee8361a6927ae6b79b68fdd33a55. Newer upstream bounded-response handling, per-profile RTB caps and Sourcepoint changes are not incorporated or qualified in this snapshot. Further merge-forward reconciliation and conflict resolution may be needed before merge. Local results above describe this exact qualified source, not a merge with the newer base or a release.