Skip to content

Plan ordered Fastly deployments after main merges - #249

Open
aram356 wants to merge 2 commits into
mainfrom
prfection/247-fastly-deploy-plan
Open

aram356 wants to merge 2 commits into
mainfrom
prfection/247-fastly-deploy-plan

Conversation

@aram356

@aram356 aram356 commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

PRfection phase: plan

Refs #247.

Auctioneer currently packages Fastly builds without deploying them. This specification and implementation plan define an ordered deployment path that reuses EdgeZero's immutable release and lifecycle actions.

The design preserves every eligible main push head, including rebase merges, and prevents later CI completion from overtaking earlier deployments. DEPLOY_ENVIRONMENT selects the existing GitHub Environment. Runtime TOML remains a variable, privately retrieved using narrowly scoped read-only API access and masked before action consumption. Recovery after possible provider mutation takes precedence over later queue progress.

The maintainer approved the written specification at 9024c1c93a6de22a8e7dc7d63aba3a50fdbcd9c1 and explicitly authorized planning publication. Both documents passed their advisory document-review loops. This is a documentation-only planning PR; implementation, hosted deployment, independent PR approval and merge are separate gates.

Validation:

  • Current document content: git diff --cached --check, cargo fmt --all -- --check and local-link checks passed.
  • Focused baseline at 9024c1c: raw JSON gate (203 fixtures/56 files), rejection fixtures, 18 libtest-summary controls and 230 socket-checker decisions passed. The socket checker ran successfully after its required RUNNER_TEMP prerequisite was configured.
  • actionlint exits 1 on both exact base d26fcf7 and head 7eed8b1, with identical SC2086 findings at .github/workflows/check-openrtb-drift.yml:24 and .github/workflows/refresh-gvl.yml:52. The detached base reproduction was cleaned after an empty ownership guard. The maintainer allowed planning to continue; these findings are not waived or marked passing.
  • The full prescribed GitHub PR matrix passed: 25/25 checks, all five workflows, for head 7eed8b12d1d323e263a65c65fef95ec98c15ea06. Actual inspected job checkouts used test merge cb0386cc3d754c7950d669ca1e517454421410fc over base d26fcf7f566db6d1dce2e1847d79c9f44581edb8.
  • External execution attribution: GitHub Actions Linux runners. CREATOR inspected all job/step outcomes and actual logs for secure/default/insecure/CLI, compiler schema, evidence producers, fanout and the three vendor builds. A full local Cargo suite and hosted-provider deployment were not run.
  • Successful workflows: Run Tests, Run Format, Fastly, Cloudflare, Spin.

Selected verbatim results from GitHub-runner execution (not local execution):

$ bash .github/workflows/scripts/test/verify-evidence-producers.sh  # exit 0
 test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 18 filtered out; finished in 417.67s
 test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 18 filtered out; finished in 986.39s
$ cargo test -p auctioneer-adapter-fastly --test manifest_health_stores -- --ignored  # exit 0
 test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 3 filtered out; finished in 86.31s

The vendor builds and real local guest checks passed on GitHub's runners; these are not hosted Fastly deployment or resource-qualification results.

Skills used: PRfection Creator, Superpowers worktrees, brainstorming, writing plans and verification before completion.

@aram356

aram356 commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: Planning documents are published at 7eed8b12d1d323e263a65c65fef95ec98c15ea06. Required current-head CI is running/queued; the ready-for-review handoff waits for its results.

  • Issue: Deploy Auctioneer to Fastly after each merge into main #247. PR: Plan ordered Fastly deployments after main merges #249. Phase: plan; target: main.
  • Branch: prfection/247-fastly-deploy-plan; worktree: .worktrees/prfection/247-fastly-deploy-plan.
  • One-account mode: acting login aram356, PR author aram356.
  • Specification: the maintainer approved the written contract at 9024c1c.
  • Implementation plan.
  • Advisory spec and plan document reviews: Approved after two iterations each. These are document checks, not independent PR approval. No GitHub review threads or reviews exist at this inspection.
  • Fresh document validation: relative links, git diff --cached --check and cargo fmt --all -- --check passed. Focused shell controls and their exact counts are in the PR description.
  • actionlint: exit 1, identical two SC2086 findings on exact base d26fcf7 and this head. The user allowed planning to continue; no failure was dismissed or marked passing.
  • All 25 existing checks registered for this head across Run Tests, Run Format and the three adapter workflows. Full local suite: not run. Full current-head GitHub-runner matrix: pending; no full-suite, hosted deployment or qualification pass is claimed.
  • Cleanup removed: task-owned detached .worktrees/base-247-d26fcf7, after an empty ownership guard.
  • Cleanup kept: current worktree/branch for this open PR. The old merged .worktrees/prfection/165-rust-dependencies-plan remains guarded because of unowned target/cli-maintenance-build/workspace/docs/testing/evidence/rust-dependency-upgrade-20261112.md and target/cli-maintenance-build/workspace/crates/auctioneer-cli/src/qualification/harness/stdio.rs. Their owner must review them before removal. Other cycles and operator configuration are preserved.
  • Next actor: GitHub Actions, then CREATOR verifies actual results and completes the REVIEWER handoff. No implementation, merge or provider deployment has occurred.

@aram356

aram356 commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: Ready for REVIEWER's planning review at 7eed8b12d1d323e263a65c65fef95ec98c15ea06.

  • Issue: #247; PR: #249; phase: plan; target: main.
  • Branch: prfection/247-fastly-deploy-plan; worktree: .worktrees/prfection/247-fastly-deploy-plan.
  • Account mode: one-account. Acting login and PR author: aram356.
  • Approved specification and implementation plan. Human written-spec approval covers 9024c1c; both advisory document reviews are Approved after two iterations. These are not independent PR approval.
  • Readiness readback: OPEN, non-draft, intended head and base verified.
  • Required GitHub CI: 25/25 checks passed, all five workflows. Actual job checkouts used merge cb0386cc3d754c7950d669ca1e517454421410fc over base d26fcf7. All job/step outcomes and selected native, compiler/evidence, conformance and vendor/guest result logs were inspected. Exact commands/result lines and workflow links are in the updated PR description.
  • Execution attribution: GitHub Actions Linux runners ran the full prescribed matrix. Local document checks, formatting and focused shell controls passed; a full local Cargo suite and hosted-provider deployment were not run.
  • Supplementary actionlint remains exit 1 on both exact base and head, with identical SC2086 findings in check-openrtb-drift.yml:24 and refresh-gvl.yml:52. The user allowed planning to continue; these findings are recorded, not waived or claimed passing.
  • GitHub review findings: none at the pre-handoff inspection; no threads resolved or hidden by CREATOR.
  • Cleanup removed: task-owned detached .worktrees/base-247-d26fcf7 after an empty ownership guard.
  • Cleanup kept: the current worktree and branch for this open PR. Cleanup of old merged .worktrees/prfection/165-rust-dependencies-plan remains guarded by unowned target/cli-maintenance-build/workspace/docs/testing/evidence/rust-dependency-upgrade-20261112.md and target/cli-maintenance-build/workspace/crates/auctioneer-cli/src/qualification/harness/stdio.rs; their owner must review them before removal. Other cycles and operator configuration remain preserved.
  • Next actor: REVIEWER reviews the specification and implementation plan. Implementation requires the separately approved planning merge. No merge or provider deployment is performed by this handoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant