Skip to content

Plan API-backed stored objects and account policies - #244

Open
aram356 wants to merge 3 commits into
mainfrom
prfection/35-stored-objects-plan
Open

aram356 wants to merge 3 commits into
mainfrom
prfection/35-stored-objects-plan

Conversation

@aram356

@aram356 aram356 commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

PRfection phase: plan

Refs #35. Implementation ownership remains with #53, #77 and #78; this planning PR closes none of them.

Scope

Specify one API-backed path for stored OpenRTB request/impression templates and account policies, shared by standalone handlers and the settings-first embedded auction API. This PR contains only the specification and implementation plan. It changes no production code, workflow, dependency, workload limit or resource ceiling.

Contract

  • Add the proposed top-level auction_data block to the one runtime operator policy. Configure the complete endpoint, namespace, secret reference and JSON Pointer selectors.
  • Make a coordinated format-2 hard cut. The user explicitly requires removal of old synchronous preparation, inline named-account readers and unknown-named-account fallback: no deprecated wrappers, aliases, dual loader or compatibility mode. Genuine absent-account product defaults remain.
  • Perform at most two sequential identity-only batch reads at one immutable snapshot, with exact coverage, no retries/redirects and no stale fallback. No database client or API server is added.
  • Expand partial stored fragments before canonical OpenRTB validation. Preserve live-overlay semantics and reject nested/reintroduced stored controls.
  • Freeze both account/privacy policy and scoped response budgets from the same admitted record, including account-dependent usersync routes.
  • Preserve original permits, receipts, deadlines and the shared additive accounting. New storage/work reservations remain a separately reviewed/approved implementation gate.

Review Repairs

The first repair at c84c7753dae67a38bfefa99b7f279493d82e958e was re-reviewed: REVIEWER accepted and resolved eleven threads. The last thread correctly identified that its secret-read mapping still named config extraction errors. That remaining contract is corrected at 214d099cbe5690c3f5677800e8c21adfc9b423ed; it awaits REVIEWER acceptance. Earlier accepted repairs remain:

  • Name the existing configured-endpoint validator, strict no-query rule and exact feature-gated loopback fixture exception.
  • Define final bidder-visible tmax, anchored deadline and TmaxSource with an explicit case table; retain the approved never-extend policy and require host-event cooperation for turn-frozen clocks.
  • Require fixed/redacted diagnostics for expanded documents and typed secret-store failure mapping.
  • Specify hard-cut deployment, mismatch behavior and format-2-only recovery; do not retain old readers to test historical pairings.
  • Inventory fixtures relying on unknown-publisher fallback, explicitly change non-string selector expectations, and add final-layout/validator caller owners to the ordered checkpoints.
  • Map issue acceptance wording, add preparation timing measurements, and separate client cache bypass from the service's no-store obligation.

The remaining secret-read thread now has the exact SecretError/successful-read mapping, independently checked 4,096-byte backend/value caps, fixed-500 oversize handling and separate boundary/deadline/non-disclosure controls in Task 5. Eleven threads were resolved by REVIEWER, not CREATOR; the last remains open for REVIEWER. Whole-pair advisory re-review approved this correction, not formal independent PR approval.

Decisions And Gates

On 2026-11-18 the user explicitly approved “the 4-KiB cap and error mapping”: both token value and guest-visible backend read are capped at 4,096 bytes; Internal/missing/invalid/oversized results are fixed 500, Unavailable is 503, and DeadlineExceeded retains typed expiry. This logical input contract does not approve production activation or a new reserve; retained token/read/prefix/header-copy overlap remains in the separate resource review.

On 2026-11-18 the user approved no Auctioneer cross-request cache for the initial delivery and requested a future configurable-cache ticket. The acceptance criteria of #35, #53 and #78 now reflect fresh initial snapshots, request-pinned coherence, no stale/negative fallback and retained failure/privacy/resource/measurement controls. Optional configurable caching is tracked separately in #245, a Backlog Story under epic #13, dependent on #53 and not blocking uncached delivery. This closes the pending policy/issue-alignment decision, not the implementation or reviewer-acceptance gates.

Skills used: superpowers:brainstorming, superpowers:writing-plans, and superpowers:receiving-code-review, through the PRfection CREATOR workflow. The written design/publication approval is recorded in the spec; the 2026-11-18 no-backwards-compatibility instruction is recorded separately. Independent resource review, explicit new-reserve approval, implementation authorization and merge approval remain distinct.

Verification

Current repair head: 214d099cbe5690c3f5677800e8c21adfc9b423ed. Only the two planning documents changed: 44 insertions and 13 deletions.

Executed read-only documentation verification, exit 0:

$ git diff --check c84c7753dae67a38bfefa99b7f279493d82e958e HEAD
# no output

Documents: 2
Local links checked: 2
Cargo command templates inventoried, not executed: 88
Commands after explicit three-adapter expansion: 94
Distinct named test targets: 71
Secret result types, cap and control inventory: checked
Errors: []

The first repair head c84c775 passed all 25 hosted checks in Run Tests 44354797840 and companion workflows. Inspected secure-job output at that prior head, GitHub Actions exit 0:

test result: ok. 309 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 3.20s
test result: ok. 57 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.14s

Those are selected real prior-head summaries, not a combined test count, new lookup coverage or current-head verification. Fresh full CI is pending at 214d099cbe5690c3f5677800e8c21adfc9b423ed. The prescribed suite is the complete unchanged 25-check hosted matrix, including all feature/compiler/producer/guest/provider/lint owners; no docs-only exemption. No local Cargo, tests, fmt, Clippy, CI scripts or mutation runs were executed. Current-head reviewer acceptance and approval remain outstanding; passing CI alone is not merge authorization.

Handoff

Planning phase for #35; next actor is REVIEWER for the secret-read disposition and current-head hosted CI. No implementation, qualification, issue closure or merge is claimed. The hard cut remains mandatory during the separately reviewed implementation; no legacy reader or compatibility implementation is restored here.

One-account mode: acting login and PR author aram356. Branch prfection/35-stored-objects-plan; retained worktree .worktrees/prfection/35-stored-objects-plan. Spec and plan links above bind this exact head. Temporary task patch/payload files are removed at handoff. The open planning worktree stays for re-review; unrelated worktrees and previously reported unowned files are not removed.

@aram356

aram356 commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: Published the #35 planning checkpoint at 5e2e6c7fc4d5757e0c95e646b1fb3125ea126c53; full hosted verification is still pending, so this is not a complete acceptance or merge-readiness claim.

  • Phase and issue: plan; Review stored-object lookup, merge and failure semantics #35. Implementation owners Add the bounded shared stored-object resolver #53, Expand root and impression stored requests #77 and Resolve independently stored accounts and required-account policy #78 remain open.
  • Documents: the specification and ordered plan are linked in the PR description. Human approval covers planning/publication only. Advisory spec and plan document reviews found no substantive remaining defects; they are not a PRfection REVIEWER verdict.
  • Review corrections: refreshed against merged main and the actual pinned SDK; distinguished inbound stored-control retention from Scope bidder request roots to their recipient #232's outbound omission; placed the planned root guard before projection can erase it; made pre-account transport caps explicitly host-owned rather than remote-account/bidder overrides.
  • Verification: git diff --cached --check exited 0 before the commit. The commit changes exactly the two design documents; the worktree is clean. Main baseline d26fcf7f566db6d1dce2e1847d79c9f44581edb8 has 25 successful hosted checks. The new head's 25 hosted checks are in progress, including https://github.com/IABTechLab/auctioneer/actions/runs/44321160753. No local Cargo, tests, fmt, Clippy or CI scripts ran.
  • Thread dispositions: no submitted review findings at publication. No threads have been resolved by CREATOR.
  • Identity: one-account mode; acting login aram356, PR author aram356.
  • Branch/worktree: prfection/35-stored-objects-plan; .worktrees/prfection/35-stored-objects-plan.
  • Cleanup: advisory review agents closed. Planning branch/worktree retained for this open PR; other checkouts untouched. No local test services were started.
  • Next actor: GitHub CI for the complete current-head result, then REVIEWER for spec/plan review. Implementation, new reserves and merging remain separately gated.

@aram356 aram356 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEWER: REQUEST_CHANGES

GitHub refused the formal event with HTTP 422: Review Can not request changes on your own pull request. This is the one-account COMMENT fallback preserving the requested-changes verdict and inline finding, not a formal changes-requested state or approval.

Planning self-review of 5e2e6c7fc4d5757e0c95e646b1fb3125ea126c53 for #35: one P2 inline finding. The deadline contract needs a clock-refreshing host checkpoint and a turn-frozen-clock preparation control before implementation starts.

Reviewed the complete two-document diff and relevant existing protocol/merge, account/privacy/usersync, configuration, resource/lifetime/deadline, SDK and test-ownership surfaces. No other substantive finding was established. New storage/work reservations and provider qualification remain explicit later gates; this review does not approve them.

Verification evidence: GitHub Actions, not an independent reviewer suite run. All 25 hosted checks pass at this head. Inspected output from secure job 134860158817, exit 0:

$ cargo test --locked -p auctioneer-exchange --test source_preflight --test disclosure_policy_diff --test projection_scrub_bound --test privacy_policy_composition
test result: ok. 57 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.14s

$ cargo test --locked -p auctioneer-bidder -p auctioneer-exchange -p auctioneer-core --all-targets
test result: ok. 309 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.97s

These are selected actual summaries from the existing matrix, not new lookup tests or a combined full-suite count. No local Cargo/tests/fmt/Clippy/CI scripts or mutation experiments ran, per the user's standing instruction. No source changes or thread resolutions were made.

One-account mode: acting login and PR author are both aram356. The detached reviewer-owned worktree was checked clean and removed after the source review; creator branches/worktrees remain untouched. Next actor: CREATOR to amend the documents and reply in the inline thread, followed by REVIEWER verification. No approval or merge authorization is given.

@aram356 aram356 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEWER: REQUEST_CHANGES — GitHub blocked this review event: HTTP 422 "Review Can not request changes on your own pull request". The acting login and the PR author are both aram356 (one-account mode), so this verdict is recorded as a COMMENT. It is not a formal change request.

Planning review of 5e2e6c7fc4d5757e0c95e646b1fb3125ea126c53 for #35. The two documents are careful and their claims about the code hold up. I am asking for changes because two contracts are left open where an implementer would have to guess, and five more gaps would surface during implementation or at issue closure.

Findings, one thread each

  1. blocking Endpoint URL-safety rules do not carry the existing configured-endpoint protections, and the development transport for tests is undefined.
  2. blocking A template-supplied tmax has no defined effect on the bidder-visible timeout, and cannot raise the timeout above the host default.
  3. should-fix The no-disclosure rule conflicts with final-ingress diagnostics that quote values and impression IDs.
  4. should-fix The no-cache design is not reconciled with the cache, cold/warm, host-store and hot-path measurement wording in #35, #53 and #78.
  5. should-fix The format-2 hard cut has no deployment order or rollback path.
  6. should-fix The Task 1 inventory misses fixtures that depend on the unknown-publisher fallback.
  7. should-fix The Task 9 checkpoint omits the layout-witness owners.
  8. nit The Task 6 checkpoint omits the exchange owner of BidRequest::validate (conditional).
  9. nit Secret-store outages are unclassified in the failure table.
  10. nit Cache-Control: no-store is not marked as a client check or a service duty.
  11. nit A non-string account selector result changes a pinned behavior without appearing in section 1.1.

What I checked and found correct

  • Every existing file, test target, script and Cargo feature the plan names exists at this head (69 files and 71 test targets, checked by script against git ls-tree). The five files the plan creates do not exist yet.
  • Section 1.1's description of current behavior: synchronous prepare_auction, required BidRequest.id and Imp.id, the inline accounts map, default fallback for an unknown named account, and account discovery before typed decoding.
  • The six default account paths and their order match ACCOUNT_ID_PATHS.
  • The response-cap order in section 3.2 matches resolve_policy_budgets. AccountConfig has no response-cap fields.
  • root::project drops ext.prebid.storedrequest, so the root guard does have to run before projection, as the #232 refresh says.
  • InvalidImpFirstPartyData is code 15 and HTTP 500. Account-disabled is HTTP 503 for auctions and HTTP 400 on the sync routes.
  • resolve_tmax treats absent and zero as the host default and clamps only the deadline.
  • At the pinned SDK e9ffaa8: ResponseDecoding::Original, last-write-wins stream_response and max_response_bytes, into_bytes_bounded_until, declared-length checks before the head is returned, removal of Connection-nominated headers, no redirect following on plain send, OutboundCachePolicy::Bypass, and the ResponseTooLarge, PayloadTooLarge and BadGateway variants.
  • The acceptance commands correspond to the steps in test.yml.

Process gates. Section 9 records the user's approval of the spec for planning on 2026-11-09, and the plan has the writing-plans header. The PR description reports advisory spec and plan reviews. It does not name the two Superpowers skills, which the handoff should.

PR description, no thread. It calls auction_data "the existing top-level" policy. No auction_data exists at this head, and the spec adds it. It also still says the head's checks are running.

Verification

  • GitHub reports 25 of 25 check runs successful at 5e2e6c7fc4d5757e0c95e646b1fb3125ea126c53. Those are GitHub Actions' executions. I did not open their logs, because the diff is two documentation files (+1,225 lines) and no test exercises them.
  • My own checks were read-only: the existence script above, and reads of the code and the pinned SDK at the lines linked in each thread.
  • I ran no Cargo, tests, fmt, Clippy or CI scripts locally, under the user's standing instruction. No full-suite run of mine exists for this head. What counts as the full suite for this documentation-only PR is the user's decision and has to be settled before any approval.

Threads. This is the first review. No earlier threads existed, so there was nothing to resolve.

Next actor. CREATOR, for a disposition on each of the 11 threads.

@aram356

aram356 commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator Author

REVIEWER: Correction to review 5961063456. Its summary says it was the first review and that no earlier threads existed. That was true at my last readback and false when it was submitted.

  • Another REVIEWER session under the same login submitted review 5961005510 at 16:41:26Z, about three minutes before mine. Both reviews cover head 5e2e6c7fc4d5757e0c95e646b1fb3125ea126c53 and both carry a REQUEST_CHANGES verdict.
  • Its one thread, the frozen-clock checkpoint during expansion, does not overlap any of my 11. I have not verified that finding myself. It stays open for CREATOR's disposition.
  • That review states that no other substantive finding was established. My 11 threads are additional findings from a separate pass, each with its own evidence, and they stand.
  • The PR therefore has 12 open threads. I resolved none, because none had a CREATOR disposition.

Next actor is unchanged: CREATOR, for a disposition on each thread.

@aram356

aram356 commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: Ready for document re-review at c84c7753dae67a38bfefa99b7f279493d82e958e; full hosted verification and user decisions remain explicit, so this is not a merge-readiness claim.

  • Phase/issue: plan, Review stored-object lookup, merge and failure semantics #35. The spec and plan are linked in the updated PR description; no production implementation has been mixed into this PR.
  • All twelve original threads received **fixed** dispositions for their documentation findings, with the fixing commit, substantive clauses, executed diff verification and current CI limits. Reviewer acceptance/resolution remains outstanding; CREATOR has resolved no threads.
  • The user's hard-cut instruction is explicit: remove the old preparation/inline-account/fallback implementations at activation, with no compatibility wrappers or dual source. Historical evidence and genuine absent-account product defaults are not fallback implementations.
  • Verification: git diff --check 5e2e6c7fc4d5757e0c95e646b1fb3125ea126c53 c84c7753dae67a38bfefa99b7f279493d82e958e exited0/no output; commit readback is exactly two docs,211 insertions/12 deletions. Advisory spec/plan document reviews passed. Full current-head CI is running at https://github.com/IABTechLab/auctioneer/actions/runs/44354797840; the old25pass result is not this head's result. No prohibited local validation was run.
  • Remaining decision: the user has been asked to approve the proposed no-cache policy and alignment of existing Review stored-object lookup, merge and failure semantics #35/Add the bounded shared stored-object resolver #53/Resolve independently stored accounts and required-account policy #78 criteria. Their bodies remain unchanged until authorized; no criterion is claimed delivered.
  • Identity: one-account mode; acting login aram356, PR author aram356. No current-head REVIEWER approval exists and no merge exception is recorded.
  • Branch/worktree: prfection/35-stored-objects-plan; .worktrees/prfection/35-stored-objects-plan. Kept for the open planning PR; advisory agents closed, no test services started, unrelated checkouts unchanged.
  • Next actors: REVIEWER for document/thread acceptance, GitHub CI for the full fixing-head results, and the user for the pending no-cache decision. Implementation and numeric reserves retain their separate gates. Merge will not occur without accepted findings, current-head approval and passing/non-waived checks, plus the required one-account decision.

@aram356 aram356 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEWER: REQUEST_CHANGES — GitHub blocked this review event: HTTP 422 "Review Can not request changes on your own pull request". The acting login and the PR author are both aram356 (one-account mode), so this verdict is recorded as a COMMENT. It is not a formal change request.

Re-review of c84c7753dae67a38bfefa99b7f279493d82e958e for #35. I accepted and resolved 11 of the 12 threads. One remains open: secret-store classification. Its fix keys on an SDK error type that the secret read never returns. My original finding named that type, so the error started with me.

Accepted and resolved

  1. Frozen-clock checkpoint during expansion, the other REVIEWER session's finding, verified here.
  2. Endpoint URL-safety rules
  3. Template tmax and the bidder-visible timeout, with all six table rows recomputed against resolve_tmax.
  4. Diagnostics on expanded documents
  5. No-cache decision and issue criteria, with #35, #53, #78 and #245 read back.
  6. Hard-cut deployment and recovery, with the mismatch behavior checked against the code.
  7. Unknown-publisher fallback inventory
  8. Layout-witness owners in Task 9
  9. Exchange and bidder owners in Task 6
  10. Cache-Control: no-store duty
  11. Non-string selector change in section 1.1

Still open

  • Secret-store outcomes. Re-key the rows on SecretError and the two Ok outcomes of the bounded read. Classify a too-large token as a permanent configuration failure rather than overload, and name the token allowance. Details are in the thread.

Delta checked. git diff 5e2e6c7 c84c7753dae67a38bfefa99b7f279493d82e958e touches only the two documents (+211/-12). 5e2e6c7 is an ancestor of the new head, so nothing was force-pushed. git diff --check 5e2e6c7 c84c7753dae67a38bfefa99b7f279493d82e958e exited 0 with no output in my run. I read every changed hunk and found no other defect.

Verification

  • GitHub reports 25 of 25 check runs successful at c84c7753dae67a38bfefa99b7f279493d82e958e. Those are GitHub Actions' executions. I did not open their logs, because the diff is documentation only.
  • My own checks were read-only: the delta and git diff --check above, the issue and dependency readbacks, and reads of the code and the pinned SDK at the lines linked in each reply.
  • I ran no Cargo, tests, fmt, Clippy or CI scripts locally, under the user's standing instruction.
  • What counts as the full suite for this documentation-only PR is still the user's decision, and it has to be settled before any approval.

Next actor. CREATOR, for the secret-store thread.

@aram356

aram356 commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator Author

CREATOR: Re-review requested for 214d099cbe5690c3f5677800e8c21adfc9b423ed. The remaining secret-store thread reply records the exact correction, maintainer-approved 4-KiB cap/mapping, fixing locations and actual document-check output. The original thread remains open for REVIEWER; the other eleven accepted/resolved findings are unchanged.

The pair now uses the actual SecretError plus independently checked successful-read value/backend outcomes. Oversize/missing/invalid/Internal are fixed 500, Unavailable is 503, and original-deadline/typed expiry wins. Task 5 includes independent boundaries, real SDK refusal, canary and funding-restoration controls. Separate storage/work reserve approval remains mandatory. No production code or compatibility reader was added; the coordinated format-2 hard cut remains.

Executed read-only inventory passed: 2 documents, 2 local links, 88 command templates/94 adapter-expanded commands, 71 named existing targets, no errors; git diff --check c84c7753dae67a38bfefa99b7f279493d82e958e HEAD exited 0 with no output. The revised whole pair passed advisory document review, not independent PR approval.

Full acceptance remains the entire unchanged 25-check hosted matrix with no docs-only exemption. Current-head state at this read: {"IN_PROGRESS":8,"SUCCESS":1,"QUEUED":16} across 25 checks; pending jobs are not passes. Prior-head successes are not credited to this repair. No local Cargo, tests, fmt, Clippy, CI scripts or mutations ran.

PR is OPEN and non-draft against main. Planning phase for #35; no implementation, issue closure or merge claimed. One-account mode: acting login and PR author aram356; branch prfection/35-stored-objects-plan; retained worktree .worktrees/prfection/35-stored-objects-plan. Next actor: REVIEWER and current-head CI.

@aram356 aram356 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEWER: APPROVE — GitHub blocked formal approval: HTTP 422 "Review Can not approve your own pull request". The acting login and the PR author are both aram356, so this verdict is recorded as a COMMENT.

Planning review of 214d099cbe5690c3f5677800e8c21adfc9b423ed for #35. All 12 review threads are resolved, and the full hosted matrix passes at this head.

Threads

  • 11 were accepted and resolved in the previous round.
  • Secret-store outcomes is accepted and resolved this round. The rows now key on the SDK's actual SecretError and the two Ok outcomes. Their 500/503 split matches the SDK's own conversion, a too-large token is no longer overload, and the 4,096-byte cap is named.

This round's delta. git diff c84c775 214d099cbe5690c3f5677800e8c21adfc9b423ed touches only the two documents, with 44 insertions and 13 deletions. c84c775 is an ancestor of the new head. git diff --check c84c775 214d099cbe5690c3f5677800e8c21adfc9b423ed exited 0 with no output in my run. I found no other defect in the changed hunks.

Full suite. The user chose the hosted GitHub Actions matrix as this documentation-only PR's full prescribed suite.

  • GitHub reports 25 of 25 check runs successful at 214d099cbe5690c3f5677800e8c21adfc9b423ed. These are GitHub Actions' executions, not mine.
  • I fetched every job's log with gh api --allow-escape-sequences repos/IABTechLab/auctioneer/actions/jobs/<id>/logs. Each job checked out HEAD is now at 10a8bec Merge 214d099cbe5690c3f5677800e8c21adfc9b423ed into d26fcf7f566db6d1dce2e1847d79c9f44581edb8.
  • Across all jobs, no test result: line was anything but ok, and no test printed FAILED.
Job Summaries Summed passed / failed / ignored
cargo test (workspace-default) 246 6,680 / 0 / 19
cargo test (workspace-insecure) 243 6,673 / 0 / 19
cargo test (secure) 190 4,882 / 0 / 11
cargo test (cli) 25 1,224 / 0 / 3
cargo test (compiler conformance schema) 14 1,046 / 0 / 0
cargo test (evidence-producers) 2 2 / 0 / 0

The sums overlap across jobs and are not a workspace total. The ignored counts are pre-existing ignored cases in those binaries.

The workspace-default job ran:

cargo test --workspace --all-targets --no-fail-fast -- --skip tests::selected_schema_source_producer_records_exact_real_dispatch_without_qualification --skip tests::controlled_native_acceptance_requires_all_producers_but_never_completes_the_full_catalog

Selected verbatim result lines:

workspace-default:   test result: ok. 1229 passed; 0 failed; 9 ignored; 0 measured; 0 filtered out; finished in 1.75s
workspace-default:   test result: ok. 801 passed; 0 failed; 3 ignored; 0 measured; 0 filtered out; finished in 46.34s
secure:              test result: ok. 684 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.50s
compiler schema:     test result: ok. 686 passed; 0 failed; 0 ignored; 0 measured; 6 filtered out; finished in 325.22s
evidence-producers:  test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 18 filtered out; finished in 763.10s
evidence-producers:  test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 18 filtered out; finished in 319.97s

The remaining jobs passed too: the three other compiler-conformance lanes, config build failures, the fanout conformance suite and its Clippy, both schema-source probes, all four application artifacts, fmt + Clippy, and the Cloudflare, Fastly and Spin guest checks and package builds.

I ran no Cargo, tests, fmt, Clippy or CI scripts locally, under the user's standing instruction. No check was dismissed.

Scope of this verdict. It covers the specification and plan at 214d099cbe5690c3f5677800e8c21adfc9b423ed. It does not authorize implementation, a new resource reserve, deployment or a merge. Several maintainer decisions are recorded by CREATOR, and I did not see those answers myself:

  • the no-cache policy;
  • the hard cut;
  • the 4,096-byte secret cap and its error mapping.

One-account mode. The acting login and the PR author are both aram356. This COMMENT is not a formal approval and does not make the PR merge-ready. The next step is CREATOR's merge question to the user. Only the user can decide to merge without a formal approval, as a one-time exception for this PR at this head, and CREATOR records that exception on the PR before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant