Repository navigation
fix(paper2code): compare tool arguments when detecting loops - #299
Open
remote-controlled-man wants to merge 1 commit into
Open
remote-controlled-man wants to merge 1 commit into
remote-controlled-man wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Paper2Code counted only tool names, so reading five different modules or writing several planned files consecutively could abort as a loop. Compare the tool name and a stable snapshot of its JSON arguments instead. Changed paths or content can proceed; repeated calls with identical arguments still stop the workflow, regardless of object key order.
Closes #294.
Changes Made
Validation
Validated at
728e90f4fa969b2f0ac3435bf95bc26abc892a30:scripts/ci/requirements.lock: 3238 passed, 43 skipped.pre-commit run --all-files --show-diff-on-failureandpython -m pip check: passed.npm run build(including version and Tauri-config checks): passed.npm run test:web, using Chromium and the real local service: 2 passed.Not run locally: Rust fmt/clippy/tests, Windows lifecycle checks, or the Python 3.13/3.14 matrix. These still need their remote CI results. No live provider calls were used. The existing large-chunk build warnings remain.
Checklist