Skip to content

test(tui): synchronize Goal editing with a running Turn - #298

Open
remote-controlled-man wants to merge 1 commit into
HKUDS:mainfrom
remote-controlled-man:codex/prflow-583916138d0b
Open

remote-controlled-man wants to merge 1 commit into
HKUDS:mainfrom
remote-controlled-man:codex/prflow-583916138d0b

Conversation

@remote-controlled-man

Copy link
Copy Markdown

Summary

The Goal TUI test used a fixed delay to keep a scripted response in flight. Piped input waits for the thread to become idle after sending a message, so automatic continuations could exhaust the Goal's no-work budget before the edit and pause commands ran.

Exercise the interactive prompt and wait for the scripted provider to start before sending the steering message. Keep the first reply pending until the REPL processes pause and prompts again. The test still checks that the steering message reaches the active Turn or is queued behind it, that editing preserves the Goal's identity, and that the paused status and updated objective persist.

Fixes #295.

Verification

  • macOS arm64, Python 3.12: the original test failed on attempt 5 with BLOCKED where it expected PAUSED. On the fix, the two focused Goal tests passed in 10 consecutive runs.
  • Ubuntu 24.04 arm64, Python 3.12: focused Goal tests passed, and the full Python suite finished with 3,233 passed and 43 skipped.
  • macOS arm64: pre-commit, dependency consistency, Desktop lint/typecheck/protocol, all 440 Desktop tests, and both Chromium Web tests passed.
  • Gitleaks, Python distribution build, Twine, and package installation verification passed.

Copilot AI balanced review requested due to automatic review settings November 5, 2026 04:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: TUI Goal edit/pause test intermittently reaches BLOCKED

2 participants