Repository navigation
test(tui): synchronize Goal editing with a running Turn - #298
Open
remote-controlled-man wants to merge 1 commit into
Open
remote-controlled-man wants to merge 1 commit into
remote-controlled-man wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Goal TUI test used a fixed delay to keep a scripted response in flight. Piped input waits for the thread to become idle after sending a message, so automatic continuations could exhaust the Goal's no-work budget before the edit and pause commands ran.
Exercise the interactive prompt and wait for the scripted provider to start before sending the steering message. Keep the first reply pending until the REPL processes pause and prompts again. The test still checks that the steering message reaches the active Turn or is queued behind it, that editing preserves the Goal's identity, and that the paused status and updated objective persist.
Fixes #295.
Verification
BLOCKEDwhere it expectedPAUSED. On the fix, the two focused Goal tests passed in 10 consecutive runs.