Repository navigation
fix(cli): compact output and surface verification failures - #365
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflect could display successful tool markers for failed shell checks, lose compiler diagnostics through retry/session wrappers, and label failed background commands as completed. Run Bash with pipefail in foreground, background, and sandbox execution; propagate command failures and cancellations as errors, retain partial output, and publish accurate background status.
Sandbox images must include Bash, matching host execution.
/testand/lintnow distinguish failed processes from denied tool calls. Failed checks retain their diagnostics in the repair context, while successful lint runs such as0 issues.do not trigger unnecessary edits.Reduce successful tool-result previews from eight lines to two, keep diagnostic tails visible for failures, and retain full expandable output. Expansion and code-copy shortcuts use the visible collapsed layout. Default prompt guidance keeps replies brief and calls for focused edits and verification.
Validation: all 156 Go packages passed with the race detector; formatting, vet, architecture boundaries, lint (zero issues), and build passed. Regression tests cover pipeline exit status, retained compiler output, background failure status, sandbox quoting, CLI test/lint repair feedback, compact previews, expansion, and code copying after collapsed results.
reflect verifyalso passed all 156 Go package checks. Its overall result remains failed because the existing local security log has a broken hash chain at entry 200; historical audit records are unchanged.