Repository navigation
fix(chat): omit tool choice on tool-free turns - #362
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small-talk turns such as “Who are you?” sent
tool_choice: "none"without any tools, causing strict OpenAI-compatible gateways to reject the request with HTTP 400. Omit tool choice when building these turns; the host continues to suppress unsolicited tool execution.Update the existing tool-free conversation checks and add regression coverage for the reported “Hi” → “Who are you?” sequence in one session. Coding turns retain their tools.
Validation: engine suite passed with the race detector;
make fmt-check lint buildpassed with zero lint issues.reflect verifypassed all 156 Go package checks; its overall result failed because the existing local security log has a broken hash chain at entry 200.