Repository navigation
Feat/openapi frontend contract - #39
Merged
Merged
Conversation
…alid tokens
Unauthenticated requests used to fail with 403 and an empty body, so a client
could not tell 'not logged in' from 'not allowed'. Now:
- 401 + {errorMessage, errorCode:UNAUTHENTICATED_ACCESS} for missing/invalid token
- 403 + {errorMessage, errorCode:ACCESS_DENIED} for authenticated without role
Tests updated where they asserted 403 for 'not authenticated' cases;
AuthErrorContractTest pins the new contract and that guest endpoints stay open.
- public operations marked security: [] (catalog, guest-visible files, /api/auth/**) - 401 documented on protected operations - every 4xx/5xx response references ErrorDTO - duplicate tag removed, /health is GET only - openapi.json regenerated and guarded by OpenApiContractTest (fails on drift)
Versioning Documentation/openapi.json meant a ~50 KB diff on every API change and silent drift. The spec is now generated from the running application in the openapi CI job and published as the 'openapi' artifact; the file is no longer tracked. Local: ./mvnw test -Dtest=OpenApiContractTest -Dopenapi.export=true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.