Repository navigation
feat!: [FLU-1105] regenerate the client from the current OpenAPI spec - #79
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Summary
Regenerates the client from the v2 serverside spec (
releases/v2/serverside-api.yaml) at chat mastere04fd5778f. The generator binary includes the fix from GetStream/chat#20015, soSortParamTypenow hasEMPTY = ''in place of the namelesspublic const = '';that broke the earlier regen.Also adds
src/GeneratedModels/MultipartRequest.php, a hand-written empty marker interface. Generated upload models (FileUploadRequest,ImageUploadRequest,UploadChannelRequest,UploadChannelFileRequest) nowimplements MultipartRequest, and nothing defined it.Webhook fixtures were regenerated too. Their payloads are unchanged; only the gzip encoding differs.
Breaking changes
getActivity()takes a new$skipOwnFollowingsbefore$userID, so positional callers that pass$userIDand later arguments must update.stopCampaign($id)andcommitMessage($id)no longer take$requestData. PHP ignores extra positional arguments, but a namedrequestData:argument now fails.Everything else is additive: new models, endpoints and optional parameters.
Tests
make lint(PHPStan) reports no errors../vendor/bin/phpunit tests --exclude-group integration: 327 tests, all pass.php -lpasses on every changed file.Made with Cursor