Repository navigation
Conversation
Forma's build embeds the folder of locale files a project's .locale.json names as localesDir, and the runtime reads each of the assembly's names without that folder. The linter read every name without .locales alone, so a project naming another folder had its files dropped or read into the wrong name. The folder is read once from the assembly's config and handed to every reader of the assembly's own names; a pack's files and an application's for other assemblies keep .locales, as the runtime reads them. A project whose items were not read is taken to embed that folder's files and its root .locale.json, as the build does.
LOC0027 and LOC0122 took a name's extension from the name itself, so a file embedded under a name of its own was read for a culture the runtime never reads it for, and a name with no extension threw. They now read a name by the format's extension, as the runtime does.
Forma's build now embeds only the JSON that carries $localization in a pack as in any other project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes candidate at 0d2a1be, whose full gate passed in run 43674782232, to main for the release of 1.0.0-preview.14. The changes are in the changelog's 1.0.0-preview.14 entry.