Repository navigation
Conversation
🦋 Changeset detectedLatest commit: f874f07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 45 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the missing X-Requested-Platform header fix in journey-client. |
| Description check | ✅ Passed | The description includes both required sections, marks the Jira ticket as N/A, and states the change. The changeset is also present in the pull request. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
ℹ️ Recent review info
-
⚙️ Run configuration
-
- Configuration used: defaults
- Review profile: CHILL
- Plan: Advanced
- Run ID:
4be54ee2-0caa-4b94-964c-8f84f83b827f
📒 Files selected for processing (4)
-
.changeset/plenty-flies-tease.mdpackages/journey-client/src/lib/journey.api.tstools/api-report/src/integration.spec.tstools/api-report/vitest.config.ts
🚧 Files skipped from review as they are similar to previous changes (1)
-
- .changeset/plenty-flies-tease.md
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
ℹ️ Recent review info
-
⚙️ Run configuration
-
- Configuration used: defaults
- Review profile: CHILL
- Plan: Advanced
- Run ID:
4be54ee2-0caa-4b94-964c-8f84f83b827f
📒 Files selected for processing (4)
-
.changeset/plenty-flies-tease.mdpackages/journey-client/src/lib/journey.api.tstools/api-report/src/integration.spec.tstools/api-report/vitest.config.ts
🚧 Files skipped from review as they are similar to previous changes (1)
-
- .changeset/plenty-flies-tease.md
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
-
Contributor
|
View your CI Pipeline Execution ↗ for commit f874f07
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
SteinGabriel
approved these changes
Sep 29, 2026
| headers.set('Accept-API-Version', 'protocol=1.0,resource=2.1'); | ||
| headers.set('Content-Type', 'application/json'); | ||
| headers.set('X-Requested-With', REQUESTED_WITH); | ||
| headers.set('X-Requested-Platform', 'javascript'); |
Contributor
There was a problem hiding this comment.
Should we be using the SDK utils property here like we do for requested with?
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🎓 Learn more about Self-Healing CI on nx.dev
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
===========================================
+ Coverage 18.07% 96.29% +78.22%
===========================================
Files 155 1 -154
Lines 24398 81 -24317
Branches 1203 17 -1186
===========================================
- Hits 4410 78 -4332
+ Misses 19988 3 -19985 🚀 New features to boost your workflow:
|
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/recognize
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
Contributor
|
Deployed b898f18 to https://ForgeRock.github.io/ping-javascript-sdk/pr-848/b898f181e3cef2ff56bdace253890f388541435a branch gh-pages in ForgeRock/ping-javascript-sdk |
Contributor
Interface Mapping Out of DateThe Drift reportTo fix, run: pnpm mapping:generateThen commit the updated |
Contributor
📦 Bundle Size Analysis📦 Bundle Size Analysis🆕 New Packages🆕 @forgerock/journey-client - 95.4 KB (new) ➖ No Changes➖ @forgerock/protect - 149.5 KB 15 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
ryanbas21
force-pushed
the
x-requested-platform
branch
from
October 5, 2026 15:19
306e89f to
05b594e
Compare
ryanbas21
force-pushed
the
x-requested-platform
branch
from
October 13, 2026 21:00
05b594e to
1fcff77
Compare
ryanbas21
force-pushed
the
x-requested-platform
branch
from
October 21, 2026 18:00
1fcff77 to
8dc21e4
Compare
ryanbas21
force-pushed
the
x-requested-platform
branch
from
October 30, 2026 19:00
8dc21e4 to
8f9c596
Compare
api-extractor invocations can be slow in CI environments. The 'should handle multiple entry points' test was timing out at the default 5000ms. Set testTimeout and hookTimeout to 30000ms in vitest.config.ts to match the actual test duration.
ryanbas21
force-pushed
the
x-requested-platform
branch
from
November 11, 2026 16:02
8f9c596 to
f874f07
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
N/A
Description
X-requested platform header missing on journey-client
Summary by CodeRabbit
X-Requested-Platformheader identifying the JavaScript platform.X-Requested-Platformheader so requests can be accepted.