Repository navigation
fix(Segments): Standardise regex matching in the Java server-side SDK - #245
Open
linear-code[bot] wants to merge 1 commit into
Open
linear-code[bot] wants to merge 1 commit into
linear-code[bot] wants to merge 1 commit into
Conversation
Match regex segment conditions from the start of the trait value without requiring a full-string match, per the Flagsmith documentation. Generated with [Linear](https://linear.app/flagsmith/agent-session/558e4f47-74c1-4a67-950a-c3bb7765c695) Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
Contributor
Author
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Contributor
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local evaluation matched
Matches regexsegment conditions anywhere in a trait value. Per the Flagsmith docs, patterns must match from the start of the value without having to cover all of it. Soprodshould matchproductionbut notnonproduction. Identities could previously land in segments they don't belong to under local evaluation. The engine now usesMatcher.lookingAt()in place offind().matches()would have wrongly required a full-string match.Changes
prod|devmatchesdevelopmentbut notnondev).^…$still require a full-value match. Matching stays case-sensitive, and invalid patterns still never match.Closes SDK-25
Review effort: 1/5