Skip to content

ci: Run @events spec tests - abandoned - #239

Open
renovate[bot] wants to merge 4 commits into
mainfrom
renovate/sdk-spec
Open

ci: Run @events spec tests - abandoned#239
renovate[bot] wants to merge 4 commits into
mainfrom
renovate/sdk-spec

Conversation

@renovate

@renovate renovate Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
Flagsmith/sdk-spec minor v0.3.0 → v0.7.0
Flagsmith/sdk-spec workflow minor v0.3.0 → v0.7.0

Release Notes

Flagsmith/sdk-spec

v0.7.0

Compare Source

What's Changed
New Contributors

Full Changelog: Flagsmith/sdk-spec@v0.6.0...v0.7.0

v0.6.0

Compare Source

What's Changed
New Contributors

Full Changelog: Flagsmith/sdk-spec@v0.5.1...v0.6.0

v0.5.1

Compare Source

What's Changed
  • ci: Run the JS client and iOS against main in the compatibility matrix by @​khvn26 in #​12
  • feat: Optionally treat steps an SDK does not implement as expected failures by @​khvn26 in #​11
  • feat: Add a testChange SDK step by @​khvn26 in #​14

Full Changelog: Flagsmith/sdk-spec@v0.5.0...v0.5.1

v0.5.0

Compare Source

What's Changed

Full Changelog: Flagsmith/sdk-spec@v0.4.0...v0.5.0

v0.4.0

Compare Source

What's Changed
New Contributors

Full Changelog: Flagsmith/sdk-spec@v0.3.0...v0.4.0

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot requested a review from a team as a code owner October 21, 2026 16:24
@renovate
renovate Bot requested review from khvn26 and removed request for a team October 21, 2026 16:24
@renovate renovate Bot added the sdk-spec Bumps of the Flagsmith SDK behavioural spec label Oct 21, 2026
@renovate
renovate Bot force-pushed the renovate/sdk-spec branch from b6d5d99 to 76feb0b Compare October 21, 2026 16:42
@renovate renovate Bot changed the title deps: update dependency flagsmith/sdk-spec to v0.4.0 deps: update dependency flagsmith/sdk-spec to v0.5.0 Oct 21, 2026
@khvn26 khvn26 added the openhands For the OpenHands agent to pick up label Oct 21, 2026
@khvn26 khvn26 changed the title deps: update dependency flagsmith/sdk-spec to v0.5.0 deps: update dependency flagsmith/sdk-spec to v0.5.1 Oct 21, 2026
@flagsmithsmith flagsmithsmith Bot mentioned this pull request Oct 29, 2026
Open
@renovate renovate Bot changed the title deps: update dependency flagsmith/sdk-spec to v0.5.1 deps: update dependency flagsmith/sdk-spec to v0.6.0 Oct 29, 2026
@renovate
renovate Bot force-pushed the renovate/sdk-spec branch from 745c7b5 to eecc3dc Compare October 29, 2026 10:32
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: bde15ea1-90af-4db3-8ae7-ccac9cedfa0b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7f0e5a49-9177-4a83-9b25-308297f11309
Commits

Reviewing files that changed from the base of the PR and between 3e778a5 and f5f3801.

Files selected for processing: 2
  • .github/workflows/sdk-spec.yml
  • sdk-spec/Steps.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The SDK spec workflow reference and spec-ref change from v0.3.0 to v0.6.0. The Java spec steps add a client configuration that enables events and sets the API and events URLs. They also add steps to retrieve an experiment flag and track events and exposure events, forwarding the supplied metadata.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · previous review f5f38

The updated spec integration has no established merge-blocking risk.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 15 untouched benchmarks

Comparing renovate/sdk-spec (0c48af8) with main (3e778a5)

Open in CodSpeed

@flagsmithsmith

flagsmithsmith Bot commented Oct 29, 2026

Copy link
Copy Markdown

Spec v0.6.0 adds @events scenarios: getting an experiment flag, tracking an event, and tracking a $flag_exposure event. CI was red because sdk-spec/Steps.java implemented only 3 of the 7 steps.

This SDK already has these features, added in #226: FlagsmithClient.getExperimentFlag, trackEvent, trackExposureEvent, and FlagsmithConfig.withEnableEvents / eventsUri. So no library change was needed. f5f3801 wires the four new steps to those methods:

  • Create the SDK client with events enabled: builds the client with FlagsmithConfig.newBuilder().baseUri(apiUrl).withEnableEvents(true).eventsUri(eventsUrl). baseUri has to be set on the config, because withConfiguration replaces whatever config withApiUrl set.
  • gets the experiment flag: getExperimentFlag(feature, identifier, traits), returned as a one-flag list.
  • tracks event and tracks an exposure: trackEvent(...) and trackExposureEvent(...), with the spec's value and metadata passed through unchanged. The SDK's own event buffer delivers them on its flush timer.

Verified locally:

  • The full v0.6.0 spec passes 7/7 against the spec's compose stack (Flagsmith 2.287.0, events API, Kafka, warehouse delivery, ClickHouse).
  • mvn verify passes: checkstyle, and 481 tests.

@renovate renovate Bot changed the title deps: update dependency flagsmith/sdk-spec to v0.6.0 deps: update dependency flagsmith/sdk-spec to v0.7.0 Oct 29, 2026
@renovate
renovate Bot force-pushed the renovate/sdk-spec branch from f5f3801 to 28bfbdb Compare October 29, 2026 19:54
@flagsmithsmith @claude
test(sdk-spec): Run the experimentation steps against the SDK
0c48af8 
Spec v0.6.0 adds scenarios for getting an experiment flag, tracking an
event and tracking an exposure event, all with events enabled. The SDK
already implements these (#226), so the steps file wires each step to
FlagsmithClient.getExperimentFlag, trackEvent and trackExposureEvent, and
creates the events-enabled client through FlagsmithConfig.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit f5f3801)
@renovate renovate Bot changed the title deps: update dependency flagsmith/sdk-spec to v0.7.0 deps: update dependency flagsmith/sdk-spec to v0.7.0 - abandoned Oct 29, 2026
@renovate

renovate Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

khvn26
khvn26 previously approved these changes Oct 30, 2026
View reviewed changes
@khvn26 khvn26 changed the title deps: update dependency flagsmith/sdk-spec to v0.7.0 - abandoned ci: Run @events spec tests Oct 30, 2026
@renovate renovate Bot changed the title ci: Run @events spec tests ci: Run @events spec tests - abandoned Oct 31, 2026
@renovate

renovate Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khvn26 khvn26 khvn26 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

openhands For the OpenHands agent to pick up sdk-spec Bumps of the Flagsmith SDK behavioural spec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@khvn26