Skip to content

release: remove unused binary signing and notarization code #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayconrod merged 1 commit into from
Nov 12, 2026
Merged

release: remove unused binary signing and notarization code #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ permissions:
contents: write

env:
# TODO(REC-55): use real certificate.
APPLE_CERT_BASE64: ${{ secrets.APPLE_DEV_CERT_BASE64 }}
# Recommended here: https://github.com/bazelbuild/bazelisk/issues/88#issuecomment-625178467
BAZELISK_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CLUSTER_HOST: opal.cluster.engflow.com
Expand Down
49 changes: 0 additions & 49 deletions infra/release-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,56 +21,11 @@ if [[ -z "${OS:-}" ]]; then
echo >&2 "OS not set"
exit 1
fi
if [[ "${OS}" == 'macos' && -z "${APPLE_CERT_BASE64:-}" ]]; then
echo >&2 "APPLE_CERT_BASE64 not set"
exit 1
fi
if [[ -z "${RELEASE_VERSION:-}" ]]; then
echo >&2 "RELEASE_VERSION not set"
exit 1
fi

APPLE_CERT_ID=
install_cert () {
if [[ "${OS}" != 'macos' ]]; then
return
fi
# Files in $RUNNER_TEMP are automatically removed on completion.
local p12_path="${RUNNER_TEMP}/build_certificate.p12"
base64 --decode <<<"${APPLE_CERT_BASE64}" >"${p12_path}"
local keychain_path="${RUNNER_TEMP}/dev.keychain"
security create-keychain -p '' "${keychain_path}"
security set-keychain-settings "${keychain_path}"
security unlock-keychain -p '' "${keychain_path}"
security import "${p12_path}" -P '' -A -t cert -f pkcs12 -k "${keychain_path}"
# Allow productsign to access the identity
# This prints some info from the keychain, not sure if it's sensitive.
security >/dev/null set-key-partition-list -S apple-tool:,apple:,codesign:,productsign: -s -k '' "${keychain_path}"
# Overwrite the keychain search list with the new keychain
security list-keychain -d user -s "${keychain_path}"
local identities_path="${RUNNER_TEMP}/identities.txt"
security find-identity -v | tee "${identities_path}"
if ! grep --quiet '1 valid identities found' "${identities_path}"; then
echo >&2 "did not find exactly 1 identity"
return 1
fi
APPLE_CERT_ID=$(grep --extended-regexp --only '\b[0-9A-F]{40}\b' "${identities_path}")
echo >&2 "Installed certificate with identity ${APPLE_CERT_ID}"
}

uninstall_cert () {
if [[ "${OS}" != 'macos' ]]; then
return
fi
security list-keychains -s ~/Library/Keychains/login.keychain
security delete-keychain "${RUNNER_TEMP}/dev.keychain"
}

sign_and_notarize_binary () {
# TODO(REC-55): implement signing and notarization for macOS and Windows.
return
}

EXT=
case "${OS}" in
macos)
Expand Down Expand Up @@ -100,11 +55,7 @@ BUILD_RELEASE_VERSION="${RELEASE_VERSION}" \
-- \
"${TARGETS[@]}"

install_cert
trap uninstall_cert EXIT

for target in "${TARGETS[@]}"; do
target_file=$(bazel cquery --output=files "${target}")
sign_and_notarize_binary "${target_file}"
cp "${target_file}" "_out/$(basename ${target_file})${EXT}"
done
Loading