Repository navigation
Sync EdgeText's shrink floor with edge-login-ui-rn - #6343
Merged
Merged
Conversation
edge-login-ui-rn ported EdgeText's minimumFontSize floor and its review reworked it. Bring those changes back so the two copies match again: - Export DEFAULT_MINIMUM_FONT_SCALE (0.65) instead of repeating 0.65. - Only compute the floor when the text is allowed to shrink. Text with shrinking off no longer carries a minimumFontSize it never uses. - Default UnscaledText's minimumFontScale to 0.65, and floor it whenever it shrinks. The fallback symbols in FiatIcon and CryptoIcon shrank with no floor before, so down to React Native's 4pt/4dp. - Document the 4pt (iOS) and 4dp (Android) defaults, how Android floors nested text runs, and that React Native 0.89 makes this unnecessary. Snapshots gain minimumFontScale on UnscaledText and drop minimumFontSize where shrinking is off.
peachbits
force-pushed
the
matthew/edgetext-min-font-parity
branch
from
November 18, 2026 08:54
37424bf to
4604550
Compare
Contributor
Author
|
This is a port from EdgeApp/edge-login-ui-rn#312 and was reviewed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings EdgeText's shrink-to-fit floor back in sync with edge-login-ui-rn, whose
EdgeTextmust match this one. login-ui ported the floor from here in EdgeApp/edge-login-ui-rn#312, and its review reworked it:DEFAULT_MINIMUM_FONT_SCALE(0.65) is exported instead of repeating 0.65.EdgeTextonly computesminimumFontSizewhen the text is allowed to shrink. Text with shrinking off no longer carries a floor it never uses.UnscaledTextdefaultsminimumFontScaleto 0.65 and floors whenever it shrinks. Before, it only floored when the caller passed a scale.patches/react-native+0.86.0.patchunnecessary.The only visible behavior change:
FiatIconandCryptoIconshrink their fallback symbol text without aminimumFontScale, so it could shrink down to React Native's 4pt/4dp floor and now stops at 65%. The longest fiat symbols (for exampleد. م.,Nfk,ден) need roughly 80% or more at the icon's font size, so they shouldn't be affected. That estimate is from the font sizes, not checked on a device.Snapshots gain
minimumFontScale={0.65}onUnscaledTextand dropminimumFontSizewhere shrinking is off.Tested: jest (170 suites, 1645 tests), tsc and eslint pass. Not tested on a device.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have: