Skip to content

feat: integrate immutable review artifacts with sandboxed orchestration - #26

Merged
wangzhizhou merged 23 commits into
mainfrom
m4/artifact-broker-orchestrator-integration
Nov 22, 2026
Merged

wangzhizhou merged 23 commits into
mainfrom
m4/artifact-broker-orchestrator-integration

Conversation

@wangzhizhou

Copy link
Copy Markdown
Contributor

Summary

Implements M4.3b orchestration wiring and tightens the M4.2 process lifecycle contract.

  • Add terminates_process_tree_on_exit to SandboxBackend capabilities; backends that cannot prove descendant cleanup are ineligible.
  • Run acceptance checks through the same mandatory SandboxManager boundary when --require-sandbox is enabled, using a sanitized environment and profile timeout.
  • Verify Runner handoff reports an enforced backend and valid effective profile digest before collecting review evidence.
  • Export review.diff and portable review-evidence.json through the Artifact Broker only after the Agent and checks finish under an enforced sandbox.
  • Store artifact ID/path in the external task journal; approvals and integration re-verify manifest hashes, task ID, base revision, review fingerprint and sandbox provenance.
  • Skip host-side evidence capture when required sandbox evidence is missing or invalid.
  • Add tests for fail-closed acceptance checks, descendant-cleanup capability, portable artifact publication and approval gating.

Security boundary / limitations

No production OS backend exists yet. Therefore --require-sandbox still fails closed before the Agent starts, and this integration cannot yet complete a sandboxed task end-to-end. Legacy unsandboxed runs continue to work but do not auto-export immutable review artifacts and cannot be treated as isolated.

The backend must prove process-tree inheritance and kill all descendants before returning; otherwise the workspace cannot be considered frozen. The Artifact Broker still uses conservative sensitive-path filtering, not a full secret scanner.

Validation

CI will run the repository quality/security gate and full unittest suite.

@wangzhizhou
wangzhizhou merged commit ce6fb53 into main Nov 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant