Repository navigation
different strategy for console exit hang - #6007
Merged
Merged
Conversation
the original approach, while conceptually cleaner, does not work in Wine/Proton because Wine's `WaitForMultipleObjects` is a pile of dog poop that almost never works this approach should address both the `FreeConsole` hangs observed with newer versions of WIndows 10 and 11 as well as avoiding Wine's deficiencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the original approach, while conceptually cleaner, does not work in Wine/Proton because Wine's
WaitForMultipleObjectsis a pile of dog poop that almost never worksthis approach should address the
FreeConsolehangs observed with newer versions of WIndows 10 and 11 as well as the original, while also avoiding Wine's deficiencieslong term still want to get off using a console for this, but that is a whole different problem