Repository navigation
ref: connect to Redis via ckan.lib.redis.connect_to_redis - #4
Merged
Merged
Conversation
`ckan.lib.jobs._connect` was removed in CKAN 2.12. `connect_to_redis` is available in CKAN 2.11 as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 12 12
Lines 566 566
=======================================
Hits 549 549
Misses 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for CKAN 2.12; still works with CKAN 2.11.
RQJobimportedckan.lib.jobs._connect, which was removed in CKAN 2.12, so enqueueing DCOR background jobs would fail there.ckan.lib.redis.connect_to_redisexists in both CKAN 2.11 and 2.12._connectin CKAN 2.11 additionally called rq'spush_connection. dcor_shared does not rely on that, because it passes the connection explicitly (Job.exists(..., connection=...)) and enqueues viatoolkit.enqueue_job.CI (CKAN 2.11): 68 tests pass in both jobs.
🤖 Generated with Claude Code