Skip to content

tests: increase coverage to 97% and report to Codecov - #2

Merged
paulmueller merged 3 commits into
DCOR-dev:masterfrom
paulmueller-agent:more-tests
Nov 5, 2026
Merged

paulmueller merged 3 commits into
DCOR-dev:masterfrom
paulmueller-agent:more-tests

Conversation

@paulmueller-agent

Copy link
Copy Markdown

Adds simple tests for parts of dcor_shared that were not tested yet and re-enables Codecov reporting.

  • New tests for parse, RQJob/rqjob_register, the CKAN config helpers (reading from ckan.ini when CKAN's config is not loaded), get_dc_instance with a missing resource, wait_for_resource (invalid ID, resource not yet in the database, artifact already on S3), iter_bucket_objects on a missing bucket, presigned URLs with a filename, make_resource_via_s3(ret_dict=True) and synchronous_enqueue_job.
  • iter_buckets_keep_non_circle never ran because it lacked the test_ prefix. It is renamed and its bucket names are fixed (the configured prefix already ends with -).
  • Removes the unused requests_toolbelt test requirement.
  • CI: uploads coverage to Codecov (same setup as the ckanext repositories: curl/gpg are installed first because the ckan-dev container lacks them) and prints missing lines.

Coverage goes from 87% to 97% (67 tests, both CI jobs pass on the fork).

🤖 Generated with Claude Code

Paul Müller and others added 3 commits November 5, 2026 10:58
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 5, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@paulmueller
paulmueller merged commit b2048f1 into DCOR-dev:master Nov 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants