Repository navigation
ref: remove unused helpers and legacy-upload fixture, use site user - #1
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup after checking all DCOR server packages (ckanext-*, dcor_control) for unused code.
Removed (not referenced by any DCOR package or ansible-for-dcor)
paths.get_nginx_config_path,paths.get_supervisord_worker_config_path,paths.get_uwsgi_config_pathmime.VALID_FORMATStesting.create_with_upload_no_temp: pytest fixture for uploading resources via CKAN, which is rejected by BREAKING: reject resource uploads via CKAN (legacy uploads) ckanext-dcor_schemas#44. Its only remaining reference is an unused import in ckanext-dc_view, removed in ref: remove unused admin_context, click_echo, and test import ckanext-dc_view#11 (merge that first, otherwise the dc_view "develop" CI job fails).Fixed
get_resource_infoandwait_for_resourceused a context with the hard-coded user"default", which is the site user only ifckan.site_idisdefault. Newadmin_context()looks up the actual site user (same fix as in ckanext-dcor_depot, -dcor_schemas, -dc_serve).CHANGELOG: 1.1.0 (BREAKING because of the removed public names).
🤖 Generated with Claude Code