Repository navigation
modemmenu: pass the caller's SIP address (DMODEM_PEER) on to the BBS - #18
Merged
Merged
Conversation
app_dmodem's DMODEM_PEER (the address a call came from by SIP), from the
environment or the session header, is now {peer} and MODEM_PEER: in the
selection's environment and session file, and in the header written to a
BBS behind the menu, which places a caller without a caller ID by it
(D-Modem/bbs#45, D-Modem/D-Modem#108).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B82eRSVXNfvCFNooYkqeMp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sydney · project thread
When modemmenu sits in front of the BBS, the caller's location info now reaches the BBS too.
DMODEM_PEER, the address the call came from by SIP (app_dmodem, mod_dmodem: send DMODEM_PEER (the caller's SIP address) D-Modem#108). modemmenu reads it from its environment or from the session header (-serve).{peer}placeholder andMODEM_PEER. That puts it in the selection's environment and session file, and in the header modemmenu writes to a BBS behind it. The BBS readsMODEM_PEERand uses it to place a caller with no caller ID (Where users call from: filled in at sign-up, shared with sysops if they agree bbs#45).MODEM_CALLERID, so caller ID locations already worked behind modemmenu.Tests:
TestHeadercovers the header round trip andDMODEM_PEERin the server's environment; the e2e test checksMODEM_PEERin a selection's environment.make testpasses.Generated by Claude Code