Skip to content

ci: grep the wheel's METADATA from a file, not a pipe (defensive) #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasr78 merged 1 commit into from
Nov 9, 2026
Merged

ci: grep the wheel's METADATA from a file, not a pipe (defensive) #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,10 @@ jobs:
test -f "dist/$PACKAGE-$VERSION.tar.gz"
test -f "dist/$PACKAGE-$VERSION-py3-none-any.whl"
test "$(ls dist | wc -l)" -eq 2
unzip -p "dist/$PACKAGE-$VERSION-py3-none-any.whl" "$PACKAGE-$VERSION.dist-info/METADATA" | grep -qx "Version: $VERSION"
# METADATA goes to a file first. grep -q exits at the Version line, so unzip piped into it could
# still be writing (it writes 64 KB at a time), get SIGPIPE and fail the step under pipefail.
unzip -p "dist/$PACKAGE-$VERSION-py3-none-any.whl" "$PACKAGE-$VERSION.dist-info/METADATA" > "$RUNNER_TEMP/METADATA"
grep -qx "Version: $VERSION" "$RUNNER_TEMP/METADATA"

# The tests run against the built wheel, installed outside the checkout, so they see what users get.
# The `live` tests run too when the CONVERTAPI_SECRET secret exists.
Expand Down
Loading