Skip to content

ci: list the tarball into a file before the release check greps it (tar | grep -q race) #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasr78 merged 1 commit into from
Nov 9, 2026
Merged

ci: list the tarball into a file before the release check greps it (tar | grep -q race) #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,10 @@ jobs:
test -f "$TGZ"
PKG_JSON=$(tar -xzOf "$TGZ" package/package.json)
[ "$(jq -r .version <<<"$PKG_JSON")" = "$VERSION" ] || { echo "::error::$TGZ does not carry version $VERSION"; exit 1; }
tar -tzf "$TGZ" | grep -qx 'package/lib/index.js' || { echo "::error::$TGZ has no lib/index.js"; exit 1; }
# The listing goes to a file first. Piped into grep -q, tar can still be writing when grep exits
# at its first match; tar then fails ("stdout: write error") and pipefail reports a missing file.
tar -tzf "$TGZ" > "$RUNNER_TEMP/tgz-files.txt"
grep -qx 'package/lib/index.js' "$RUNNER_TEMP/tgz-files.txt" || { echo "::error::$TGZ has no lib/index.js"; exit 1; }
tar -tzf "$TGZ"

# Trusted Publishing: once npmjs.com trusts this repository, publish.yml and the npm environment,
Expand Down
Loading