Skip to content

ci: read the class file version from a file, not a pipe into od -N1 (defensive) #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasr78 merged 1 commit into from
Nov 9, 2026
Merged

ci: read the class file version from a file, not a pipe into od -N1 (defensive) #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,11 @@ jobs:
for f in "convertapi-$VERSION.jar" "convertapi-$VERSION-sources.jar" "convertapi-$VERSION-javadoc.jar"; do
test -f "target/$f" || { echo "::error::target/$f was not built"; exit 1; }
done
# Class file major version 52 = Java 8, which the library still supports.
MAJOR=$(unzip -p "target/convertapi-$VERSION.jar" com/convertapi/client/ConvertApi.class | od -An -j7 -N1 -tu1 | tr -d ' ')
# Class file major version 52 = Java 8, which the library still supports. The class goes to a
# file first: od stops reading after byte 8, so unzip piped into it could still be writing (it
# writes 64 KB at a time), get SIGPIPE and fail the step under pipefail.
unzip -p "target/convertapi-$VERSION.jar" com/convertapi/client/ConvertApi.class > "$RUNNER_TEMP/ConvertApi.class"
MAJOR=$(od -An -j7 -N1 -tu1 "$RUNNER_TEMP/ConvertApi.class" | tr -d ' ')
[ "$MAJOR" = 52 ] || { echo "::error::The classes are compiled for class file version $MAJOR, not 52 (Java 8)"; exit 1; }
echo "version=$VERSION" >> "$GITHUB_OUTPUT"

Expand Down
Loading