Skip to content

fix(mkconcore): copy MATLAB literal helper files into generated studies - #672

Open
yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:fix/matlab-literal-helpers
Open

yadavchiragg wants to merge 1 commit into
ControlCore-Project:devfrom
yadavchiragg:fix/matlab-literal-helpers

Conversation

@yadavchiragg

Copy link
Copy Markdown

Fixes #648

Problem: concore_read.m, concore_write.m, concore_initval.m and concore_default_maxtime.m call concore_literal_eval and concore_literal_serialize, but mkconcore.py never copied those two files into the generated src/ folder. A MATLAB/Octave node would fail on its first read or write.

Change: copy both helpers alongside the other concore_.m runtime files. The generated build scripts already copy concore_.m with a wildcard, so no change was needed there. mkconcore.py has mixed line endings, so the edit keeps the existing ones.

Testing: new tests/test_matlab_runtime_files.py generates demo/sampleM.graphml for posix, windows and docker. It checks both helpers are in src/, that every concore_* function called by a copied runtime file is itself copied, and that the build script still uses the concore_*.m wildcard. 6 of the 8 tests fail on current dev and pass with this change. ruff format --check and ruff check are clean.

Not run under real MATLAB or Octave, only checked at the generated-files level.

@github-actions

Copy link
Copy Markdown

🎉 Welcome aboard, @yadavchiragg! Thank you for your first pull request in concore.

Please ensure that you are contributing to the dev branch.

Your contribution means a lot to us. We'll review it shortly.

Please ensure you have reviewed our:

If you have any questions, feel free to ask. Happy coding!

@yadavchiragg
yadavchiragg changed the base branch from main to dev November 13, 2026 03:03
@yadavchiragg
yadavchiragg force-pushed the fix/matlab-literal-helpers branch from c779ee3 to 5668c95 Compare November 13, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MATLAB/Octave nodes get empty reads: concore_literal_eval.m / concore_literal_serialize.m are not copied into studies

1 participant