Repository navigation
fix(julia): keep list values when loading concore.params - #671
Open
bhuvan-somisetty wants to merge 2 commits into
Open
bhuvan-somisetty wants to merge 2 commits into
bhuvan-somisetty wants to merge 2 commits into
Conversation
The comma-in-value tryparam test wrote concore.params to in/1/, but load_params reads from inpath + "1/concore.params" (in1/), so it never found the file. ubuntu-latest now resolves to 26.04, where setup-python has no 3.9 build. Pin the Python test matrix to ubuntu-24.04 so 3.9 keeps running. Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>
load_params!() split dict values on the first comma, so a list like
[1.0, 2.0, 3.0] became the string "[1.0". Split items at the top level
only and parse list values into Vector{Float64}, same as the Python side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #670
julia's load_params!() was cutting list values at the first comma, so
{'setpoint': [1.0, 2.0, 3.0]}came back as"[1.0". it now splits only on top-level commas and parses lists intoVector{Float64}, same as python. also handleskey=[...]in the semicolon format. same change in concore.jl and concoredocker.jl, with tests for both.also carries the ci fix from #662 (c++ tryparam test path + ubuntu-24.04 pin) since dev ci is red without it.