Repository navigation
fix: handle comma-containing values in parsedict() - #611
Merged
pradeeban merged 1 commit intoNov 2, 2026
Merged
Conversation
avinxshKD
force-pushed
the
fix/parsedict-comma-nesting
branch
from
October 12, 2026 18:06
f25c36e to
7e7da21
Compare
Member
|
Welcome back @avinxshKD. Got some time to finally look at the PRs. |
Contributor
Author
|
@pradeeban ay ay Captain, always here. theres gonna be lots of not so needed PRs for you to look now lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parsedict() was splitting on
,withstd::getline, which breaks whenever a value contains a comma (nested lists, tuples, etc.) and silently drops any keys that follow.Swapped the naive comma split to reuse the existing parse_literal_value / parse_literal_string parser already in concore_base.hpp, which properly tracks quote and bracket nesting depth. Also added regression coverage in TestConcoreHpp.cpp.
Fixes #610