Skip to content

docs: add the missing README logo - #35

Open
manuel-ts-14 wants to merge 1 commit into
mainfrom
CXH-3938/add-readme-logo
Open

manuel-ts-14 wants to merge 1 commit into
mainfrom
CXH-3938/add-readme-logo

Conversation

@manuel-ts-14

Copy link
Copy Markdown

Summary

The README's first line is ![Baton Logo](./docs/images/baton-logo.png), but the repo has no file at that path, so GitHub shows a broken image. This adds the same 64,445-byte logo that ships in other baton-* repos at that path (copied from baton-okta, identical git blob 9daaea4d).

No code, config or README text changes.

🤖 Generated with Claude Code

The README's first line points at ./docs/images/baton-logo.png, which did
not exist. Add the same logo other baton-* repos ship at that path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@manuel-ts-14
manuel-ts-14 requested review from a team and luisina-santos November 12, 2026 18:56
@linear-code

linear-code Bot commented Nov 12, 2026

Copy link
Copy Markdown

CXH-3938

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor
Superseded — see the current review report for commit 131d49ff31f6

Connector PR Review: docs: add the missing README logo

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base e7ebcc3f0537.
Review mode: full
View review run

Review Summary

This PR adds one binary file, docs/images/baton-logo.png. It is a valid PNG (2121×590 RGBA, git blob 9daaea4d, matching the PR description), stored at the path that README.md:3 already points to (./docs/images/baton-logo.png). Adding it fixes the broken image in the README. I scanned the full PR diff for security and correctness problems. No Go code, config, dependency manifests, provisioning code or API endpoints changed. The trusted repo-local criteria loaded, but none of their sections apply to a static image: logging, error wrapping, spans, JSON types, breaking changes, provisioning, ID stability and sync data loss all need code changes to trigger. The docs/connector.mdx staleness checks don't apply either, because no capabilities, scopes or config changed. There were no prior findings to audit, and nothing in the change went unreviewed.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Connector PR Review: docs: add the missing README logo

Blocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base e7ebcc3f0537.
Review mode: full
View review run

Review Summary

This PR adds one binary file, docs/images/baton-logo.png. It is a valid PNG (2121×590 RGBA, git blob 9daaea4d, matching the PR description), stored at the path that README.md:3 already points to (./docs/images/baton-logo.png). Adding it fixes the broken image in the README. I scanned the full PR diff for security and correctness problems. No Go code, config, dependency manifests, provisioning code or API endpoints changed. The trusted repo-local criteria loaded, but none of their sections apply to a static image: logging, error wrapping, spans, JSON types, breaking changes, provisioning, ID stability and sync data loss all need code changes to trigger. The docs/connector.mdx staleness checks don't apply either, because no capabilities, scopes or config changed. There were no prior findings to audit, and nothing in the change went unreviewed.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

None.


Reviewed commit: 131d49ff31f6

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found — see the full review report

@carolinaroncaglia carolinaroncaglia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asset is right, the location is the legacy one.

ConductorOne/baton-template keeps baton-logo.png at the repo root and opens its README with ![Baton Logo](./baton-logo.png) (template/README.md:1, template/baton-logo.png). That is what baton-admin scaffolds every new connector repo from. Adding the file under docs/images/ makes the existing reference resolve, but it fixes the repo into the shape the template moved away from.

Across the 487 baton-* repos in the org:

Shape Repos Reference resolves
./baton-logo.png (template) 133 133 of 133
./docs/images/baton-logo.png 76 40 of 76
no logo line 278 n/a

Every broken logo reference in the fleet is in the second row. The image itself is a single blob, 9daaea4d, 64,445 bytes, byte-identical in the template and in every repo that carries it, so this is only about where the file sits.

Two changes instead of one: put baton-logo.png at the repo root, and change README.md:1 to ![Baton Logo](./baton-logo.png).

Same note on the other eight PRs in this batch. 27 more repos carry the broken docs/images reference and no PR covers them yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants