Skip to content

London | 26-ITP-Sep | Mars Adesina | Sprint 1 | Data groups - #1494

Open
marscancode wants to merge 59 commits into
CodeYourFuture:mainfrom
marscancode:coursework/data-groups-sprint-1
Open

London | 26-ITP-Sep | Mars Adesina | Sprint 1 | Data groups#1494
marscancode wants to merge 59 commits into
CodeYourFuture:mainfrom
marscancode:coursework/data-groups-sprint-1

Conversation

@marscancode

@marscancode marscancode commented Nov 5, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1071

Changelist

I have completed the Sprint 1 tasks, working through the JavaScript functions and making sure they work as expected. I have also run the tests to check that everything is working correctly.

@marscancode
fixed median calculation for odd and even arrays
2071acd
@marscancode
Sorted a copy before calculating the median
19742a7
@marscancode
Added a check in function to make sure the input is an array
aca8e91
@marscancode
Added a a check in function for empty arrays
091e875
@marscancode
added check in function that the array only contains numbers
c4d3648
@marscancode
removed duplicate values from arrays
fc92cc2
@marscancode
added describe median function
a078653
@marscancode
Added tests for describeMedian
e02094b
@marscancode
Ignore prep directory
1875b30
@marscancode
Implemented findMax function
f9a47c7
@marscancode
added empty and single-number tests for findMax
1516690
@marscancode
Added test for both positive and negative numbers
445b260
@marscancode
Add test for array with negative numbers
4337038
@marscancode
added test for decimal numbers
6fd0acf
@marscancode
added test for value that isnt a number
8490f09
@marscancode
Completed findMax tests
7b42dd0
@marscancode
added first test for calculateMean, it fails
9f17e6d
@marscancode
implemented function calculateMean
19d9c71
@marscancode
test to check wether calculateMean works given an array with a single…
063182a 
… number, it passes
@marscancode
test to check how calculateMean handles an array of negative numbers,…
1b1468e 
… it passes
@marscancode
test to check wether calculateMean handles an array of decimal number…
d90b2cf 
…s, it passes
@marscancode
added test to check wether calculateMean throws an error when given a…
7547c25 
…n empty array, it fails
@marscancode
implemented calculateMean to handle empty arrays
c87f412
@marscancode
test to check if calculateMean throws an error when given a string in…
f24628a 
…stead of an array
@marscancode
implemented calculateMean to handle a string, tests pass
c574535
@marscancode
added tests for calculateMean for invalid non-array values
c427aa2
@marscancode
deleted duplicate empty array test
108c621
@marscancode
added test to check if calculateMedian throws an error when given an …
03ec939 
…array with a non-number value
@marscancode
implemented calculate mean to only take in arrays with number values
3048952
@marscancode
added test for empty sum array
e6bec3a
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 5, 2026
@marscancode marscancode added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 6, 2026
@cjyuan

cjyuan commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Changes look good.

Comments professionally addressed.

You might have missed this comment: #1494 (comment)

What should calculateMean([Infinity, 0, -Infinity]) return?

Infinity is also a value of type "number".

Could you address it too?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 6, 2026
@marscancode

marscancode commented Nov 6, 2026

Copy link
Copy Markdown
Author

Thanks for pointing this out! I've added tests for both calculateMean and sum to check how they handle Infinity values. Both functions allow Infinity and return NaN when positive and negative Infinity are added together.

Changes look good.

Comments professionally addressed.

You might have missed this comment: #1494 (comment)

What should calculateMean([Infinity, 0, -Infinity]) return?

Infinity is also a value of type "number".

Could you address it too?

@marscancode marscancode added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 6, 2026
@cjyuan

cjyuan commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

All good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marscancode @cjyuan