You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Mirror HDX-4376 implicit→body fallback in MCP query tools and alert templates #2355
Follow-up to #2354 (HDX-4376), which added a bare-text Lucene search fallback from `implicitColumnExpression` to `bodyExpression` on log sources.
The UI flow is fixed. For consistency, the same fallback needs to be threaded through backend paths that build their own `ChartConfigWithDateRange` from a source:
`packages/api/src/tasks/checkAlerts/template.ts` (sample-log query in alert template rendering)
For each: when the source is a log source, pull `source.bodyExpression` alongside `source.implicitColumnExpression` and pass both to the chart config. Trace sources stay unchanged.
The schema change in #2354 already added `bodyExpression` to `_ChartConfigSchema` and `RawSqlChartConfigSchema`, so this is purely callsite-level plumbing.
No test coverage gap to backfill: `CustomSchemaSQLSerializerV2` itself is tested in common-utils. The callsites just need to thread the field through.
I can take this. I’ll pass the log source bodyExpression through the MCP and alert query configs listed above, preserve explicit implicitColumnExpression precedence and trace-source behavior, and add regression tests for the affected paths.
Activity
ntmspavan commentedon Nov 16, 2026
I can take this. I’ll pass the log source bodyExpression through the MCP and alert query configs listed above, preserve explicit implicitColumnExpression precedence and trace-source behavior, and add regression tests for the affected paths.