Repository navigation
chore(#13): gitignore the vendored JDK 8 build tooling (win-linux-mac channel restoration) - #14
Merged
Merged
Conversation
The 5.12 hotfix line builds through Gradle 6.5, incompatible with the system JDKs (21/25); the working JDK 8 runtime vendors at .tools/jdk/ per the BoundPronouns repo's /.tools/jdk pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13
Summary
Restores the win-linux-mac desktop channel end-to-end: the 5.12-line dist task's missing-assets packaging defect (every desktop jar ever shipped — including the published 2021 one — was engine-only and unplayable standalone) is fixed on the
hotfix/5.12maintenance branch, a content-complete jar was rebuilt, accepted by an executed full play-through, deployed to the paired itch project, and verified live. This PR carries the spec's one tracked change: gitignoring the vendored JDK 8 build runtime (Gradle 6.5 is incompatible with the system JDKs; vendors at.tools/jdk/per the BoundPronouns pattern).Changes
.gitignore:/.tools/jdk/(the vendored runtime itself stays local-only)Evidence
unzip -l: 3,560 entries = 2,274 classes + 28 natives + 1,258 data (457 challenge images incl.ani.png, 421 challenge audio takes), md5-identical across two independent buildsAnimals-5.12.jar56 MB (win/linux/mac icons) + unchangedAnimals-5.12-release.apk52 MB (android).tools/jdk/bin/java -version→ Temurin 1.8.0_512; the rule lands on this branch, merge-tree-clean against the open Spec: convert the Animals repo's deploy target to itch.io (standard itch.io deployment) #11 PR.issues/13/audit/validation.yaml)Provenance
.issues/13/(spec validated rounds 1–5 + revision loop 6–9 ending PASS; plan validated round 1)hotfix/5.12=36720a1on tag5.12(678cd19) — never merges forward; Godot replaces it🤖 Co-authored with AI: OpenCode (huggingface/zai-org/GLM-5.3-Flash)