Skip to content

CI: run the tests, with the template tests on a clone of the template's main - #4

Merged
IvanHCenalmor merged 4 commits into
mainfrom
claude/fix-placeholders-40
Nov 12, 2026
Merged

IvanHCenalmor merged 4 commits into
mainfrom
claude/fix-placeholders-40

Conversation

@IvanHCenalmor

@IvanHCenalmor IvanHCenalmor commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #3 (CellMigrationLab/LabConstrictor#40).

Problem

This repository has no CI, and the three template tests of tests/test_placeholders.py (added in #3) are skipped unless LC_TEMPLATE_DIR points to a copy of the template. A placeholder added to the template later that the form does not fill in would go unnoticed until a broken installer.

Change

  • New .github/workflows/tests.yml: on every push to main, every pull request, every Monday and on demand, it checks out this repository and the template's main (CellMigrationLab/LabConstrictor), sets LC_TEMPLATE_DIR to the template, installs requirements.txt and runs python -m unittest discover -s tests -v.
  • Actions are pinned by commit SHA, and both checkouts use persist-credentials: false.

This branch first carried its own version of the initialiser fix (initializer.py, tests/test_initializer.py). #3 was merged with the same fix, so that version was dropped: the diff against main is now only the workflow.

Verified

  • LC_TEMPLATE_DIR=<copy of LabConstrictor main> python -m unittest tests.test_placeholders -v: 6 tests OK, including the 3 template tests.
  • The template now also holds .tools/python/check_placeholders.py, which names every placeholder on purpose; the template tests here check only app/, setup.py and construct.yaml, so it does not affect them.

🤖 Generated with Claude Code

IvanHCenalmor and others added 4 commits November 12, 2026 13:21
…orkflow

#3 already fills PYTHON_PROJ_NAME and PROJECT_NAME in the installer scripts (placeholders.py), so this branch
drops its own initializer.py and tests/test_initializer.py. The workflow checks out the template's main and sets
LC_TEMPLATE_DIR, so the template tests of tests/test_placeholders.py run on every push and every week instead of
being skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…I workflow

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@IvanHCenalmor IvanHCenalmor changed the title Fix placeholder issues CI: run the tests, with the template tests on a clone of the template's main Nov 12, 2026
@IvanHCenalmor
IvanHCenalmor merged commit eb71ccc into main Nov 12, 2026
1 check passed
@guijacquemet
guijacquemet deleted the claude/fix-placeholders-40 branch November 15, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant