Repository navigation
CI: run the tests, with the template tests on a clone of the template's main - #4
Merged
Merged
Conversation
…orkflow #3 already fills PYTHON_PROJ_NAME and PROJECT_NAME in the installer scripts (placeholders.py), so this branch drops its own initializer.py and tests/test_initializer.py. The workflow checks out the template's main and sets LC_TEMPLATE_DIR, so the template tests of tests/test_placeholders.py run on every push and every week instead of being skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…I workflow Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3 (CellMigrationLab/LabConstrictor#40).
Problem
This repository has no CI, and the three template tests of
tests/test_placeholders.py(added in #3) are skipped unlessLC_TEMPLATE_DIRpoints to a copy of the template. A placeholder added to the template later that the form does not fill in would go unnoticed until a broken installer.Change
.github/workflows/tests.yml: on every push tomain, every pull request, every Monday and on demand, it checks out this repository and the template'smain(CellMigrationLab/LabConstrictor), setsLC_TEMPLATE_DIRto the template, installsrequirements.txtand runspython -m unittest discover -s tests -v.persist-credentials: false.This branch first carried its own version of the initialiser fix (
initializer.py,tests/test_initializer.py). #3 was merged with the same fix, so that version was dropped: the diff againstmainis now only the workflow.Verified
LC_TEMPLATE_DIR=<copy of LabConstrictor main> python -m unittest tests.test_placeholders -v: 6 tests OK, including the 3 template tests..tools/python/check_placeholders.py, which names every placeholder on purpose; the template tests here check onlyapp/,setup.pyandconstruct.yaml, so it does not affect them.🤖 Generated with Claude Code