Repository navigation
Template 0.1.34: installers use LabConstrictor-Tools v0.3.0-alpha.4 - #58
Merged
Merged
Conversation
Tools v0.3.0-alpha.4 (LabConstrictor-Tools #165, feature result_axes_v1) writes a result with known axes (Axes, or the new WithAxes) as an ImageJ hyperstack, so Fiji opens a time-lapse with its time points and slices instead of one long stack. The migration moves LC_TOOLS_PIN in post_install.sh and .bat from v0.3.0-alpha.3 to v0.3.0-alpha.4 only where the line still holds the template's old value. tests/_v0_1_34.py moves the pin back for the older migrations' tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Scma6VXx7mT1FYsKmB1184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why. Tools v0.3.0-alpha.4 (CellMigrationLab/LabConstrictor-Tools#165, feature
result_axes_v1) writes a result whose axes are known (declared withAxes, or returned with the newWithAxes) as an ImageJ hyperstack. Fiji then opens a time-lapse with its time points and slices instead of one long stack; napari and notebooks read the same array as before. The tagv0.3.0-alpha.4exists (commit 42c8774).What it changes
v0_1_33_to_v0_1_34.py: movesLC_TOOLS_PINinpost_install.sh/.batfromv0.3.0-alpha.3tov0.3.0-alpha.4, only where the line still holds the template's old value. An app's own pin is left alone and logged. This is the same code as the 0.1.33 pin step..tools/docs/migration_0_1_34.md.test_template_sync_0_1_34.pyis new.tests/_v0_1_34.pymoves the pin back for the older tests, chained from_v0_1_33.py.test_template_sync_0_1_33.pynow compares through itslive()helper and no longer pins the current version.Checks
v0.3.0-alpha.4tag: all cases pass.z:1/20 t:1/4.Generated by Claude Code