Repository navigation
Site review: correct page text; keep app text and bad apps from breaking the site - #32
Merged
Merged
Conversation
…ing the site Page text (hand-written here): - How it works: template updates are optional and come after the first release (as the template says); code cells can be hidden or shown by default; a licence is recommended, not required (also on Submit). - Demo: the QuPath extension is no longer called a prototype; the connection steps name all three programs. Use page and Docs home: the demo covers Windows and macOS; the napari picture is no longer called a prototype. - Guide titles in the sidebar, pager and Docs list are plain text (no backticks). - A 404 page with a title and links to Home, the App Centre and Docs. - The App Centre gets "Edit this page on GitHub"; the footer's Cite link goes to #cite. Untrusted app text and pictures: - esc() also encodes [ and ], so Markdown link syntax in an app's text is shown as written and never becomes a link (it broke the card's data-search attribute). decorate_links leaves code alone. - Pictures are fully decoded when they are downloaded, so one too large or broken leaves out that app instead of stopping the site build; file paths are quoted. - Two apps with the same summary, or short text such as '">', no longer stop the publish in check_design / check_site. check_design names pages the same on Windows. - A submission is checked against the addresses and names listed apps already use. Workflows: - publish.yml: each job gets only the permissions it needs; the build (which also runs on pull requests) can only read; the left-out-apps issue is its own job. - validate-submission.yml: the check runs with a read-only token; commenting and opening the pull request are separate jobs; one run per issue at a time; the pull request says how to start the site build on it. Smaller fixes: - gfm.lists: a heading, rule, quote, code block or HTML right after a list item, and a list of another kind, end the list as on GitHub. - App-page install steps are read at the indentation gfm.lists writes; code keeps its lines. - How it works: "Skip to content" no longer jumps to step 1; DESIGN.md matches the one-step-at-a-time page on narrow screens. - Demo: the address follows the part when the installer opens the app; the double-click selection is drawn from the state for Windows and macOS alike. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes what a full review of the site found in this repository. Fixes that belong to other repositories go there (the template's in CellMigrationLab/LabConstrictor#59).
Page text
labconstrictor-app.yamlfile".#cite, notindex.html#cite.App text and pictures (written by app authors)
data-searchattribute it broke the markup.escnow also encodes[and], and link decoration skips code.check_design;">no longer counts as unescaped incheck_site.check_designnames pages the same on every system, which removes the Windows-only false alarm on template-synchronization.Workflows
publish.ymlvalidate-submission.ymlSmaller fixes
gfm.lists): a heading, rule, quote, code block or HTML right after a list item, and a list of another kind (numbers after bullets), end the list as on GitHub.gfm.listswrites, and code keeps its line breaks. The output of the current install guide is unchanged.Checks
tests/test_app_text_safety.pyand new cases intest_gfm,test_catalogueandtest_get.check_siteandcheck_designreporting 0 problems.node --checkand the JS rule tests.🤖 Generated with Claude Code