Repository navigation
Generalise the Fiji comparison to any Zenodo dataset - #6
Merged
Merged
Conversation
compare_with_fiji.py replaces time_full_movie.py. It runs the original Fiji macro and Fast4DRegPy with the same settings on a registered dataset (synthetic-large-drift or huvec) and compares drift tables, outputs, the archived Fiji result and run times. It reuses PeakRss from process_metrics.py and keeps the strict checks: one results directory, one of each Fiji output, one 'Time taken' entry and matching output shapes. The fiji comparison workflow is manual-only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKqXa6YXedjwYhQT9vT5WN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validation/fiji/compare_with_fiji.pyreplacestime_full_movie.py. It runs the original Fiji macro and Fast4DRegPy with the same settings on a dataset from Zenodo record 7514913 and compares:Two datasets are registered:
synthetic-large-driftandhuvec. The HUVEC data has a different axial stretch factor, which is open-work item 1 in AGENTS.md.The script keeps the strict checks from the cleanup PR:
Time takenentry;It reuses
PeakRssfromprocess_metrics.py.The fiji comparison workflow replaces fiji full-movie timing. It runs only when started manually and takes the dataset as an input.
validation/README.md,docs/validation.mdandCHANGELOG.mdare updated to match.The registration code is unchanged.
Checks
ruff check src tests benchmarks validationpasses.pytestpasses: 78 tests.compare_with_fiji.py --helpruns. The script has not been run against Fiji since the strict checks were added; the HUVEC run is still to be done.🤖 Generated with Claude Code
https://claude.ai/code/session_01AKqXa6YXedjwYhQT9vT5WN
Generated by Claude Code