Skip to content

Generalise the Fiji comparison to any Zenodo dataset - #6

Merged
guijacquemet merged 1 commit into
mainfrom
claude/fast4dreg-py-audit-r2p1py
Sep 25, 2026
Merged

guijacquemet merged 1 commit into
mainfrom
claude/fast4dreg-py-audit-r2p1py

Conversation

@guijacquemet

Copy link
Copy Markdown
Contributor

Summary

  • validation/fiji/compare_with_fiji.py replaces time_full_movie.py. It runs the original Fiji macro and Fast4DRegPy with the same settings on a dataset from Zenodo record 7514913 and compares:

    • drift tables;
    • corrected outputs;
    • the archived Fiji result;
    • run times and peak memory.

    Two datasets are registered: synthetic-large-drift and huvec. The HUVEC data has a different axial stretch factor, which is open-work item 1 in AGENTS.md.

  • The script keeps the strict checks from the cleanup PR:

    • Fiji creates exactly one results directory and one of each output file;
    • the Fiji log has exactly one Time taken entry;
    • Fast4DRegPy's output has the same shape as Fiji's.

    It reuses PeakRss from process_metrics.py.

  • The fiji comparison workflow replaces fiji full-movie timing. It runs only when started manually and takes the dataset as an input.

  • validation/README.md, docs/validation.md and CHANGELOG.md are updated to match.

The registration code is unchanged.

Checks

  • ruff check src tests benchmarks validation passes.
  • pytest passes: 78 tests.
  • compare_with_fiji.py --help runs. The script has not been run against Fiji since the strict checks were added; the HUVEC run is still to be done.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKqXa6YXedjwYhQT9vT5WN


Generated by Claude Code

compare_with_fiji.py replaces time_full_movie.py. It runs the original
Fiji macro and Fast4DRegPy with the same settings on a registered
dataset (synthetic-large-drift or huvec) and compares drift tables,
outputs, the archived Fiji result and run times. It reuses PeakRss from
process_metrics.py and keeps the strict checks: one results directory,
one of each Fiji output, one 'Time taken' entry and matching output
shapes. The fiji comparison workflow is manual-only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKqXa6YXedjwYhQT9vT5WN
@guijacquemet
guijacquemet merged commit f136cba into main Sep 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants