Repository navigation
RAL-206: the Marshal e2e's shim never borrows the runner's identity - #295
Merged
Merged
Conversation
tests/marshal.rs's throwaway marshal-shim inherited CLAUDE_CODE_SESSION_ID, the first thing the shim reads to find its session. So it registered under whichever Claude Code session ran the test, with that session's id and nickname. It only ever reached the throwaway daemon, but the test depended on who ran it (fervent-dace's note on RAL-199 part 3). The shim now gets no inherited CLAUDE*, MARSHAL_* or MYKO_* variable. It is given a fixed test session id, and both e2e tests assert that id. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAL-206: the Marshal e2e's throwaway shim never borrows the identity of the session that runs it.
Why: fervent-dace noticed this while reading RAL-199 part 3. The throwaway
marshal-shimintests/marshal.rsinheritedCLAUDE_CODE_SESSION_ID, which is the first thing the shim reads to find its session. So it registered under whichever Claude Code session ran the test, with that session's id and nickname. It only ever reached the throwaway daemon, but the test depended on who ran it.Change: the shim gets no inherited
CLAUDE*,MARSHAL_*orMYKO_*variable. It is given a fixed test session id (e2e00199-…), and both e2e tests now assert that id.Tests: fmt and clippy
-D warningsare clean.cargo test --test marshal -- --ignored --nocapturepasses 3 of 3, and the shim's row readssession_id: e2e00199-0000-4000-8000-000000000199(nickname quick-gecko) rather than the runner's. Onlytests/marshal.rsand the roadmap change.🤖 Generated with Claude Code