Skip to content

RAL-205: browser tests hold up under load - #294

Merged
Castor-o7 merged 4 commits into
mainfrom
ral-205-browser-load
Nov 17, 2026
Merged

Castor-o7 merged 4 commits into
mainfrom
ral-205-browser-load

Conversation

@Castor-o7

Copy link
Copy Markdown
Owner

RAL-205 (claim 5506), from the watchman, after RAL-203's local/check failed in a_segfault_at_start_is_tried_once_more_and_a_second_fails at load ~7. After the stand-in's crash at start, the retry's real Chrome hadn't started before the run's 45 s timer fired. Agreed with upbeat-anole, since web is their side.

  • tests/web.rs: one real Chrome at a time. The 12 browser runs ran in parallel test threads, so several flatpak Chromes started at once. The lock is held only around the browser's run, not the viewer's setup. It's taken with unwrap_or_else(|p| p.into_inner()), so a panicking test doesn't poison the rest.
  • tests/browser/sign-in.mjs: the retry after a crash at start gets a fresh 45 s budget, and a 90 s cap from the script's start ends any run.
  • docs/roadmap.md: the RAL-205 entry.

The assertions are unchanged: one stated retry, a second crash fails, and nothing of the browser survives.

Evidence at aa78c78:

  • cargo fmt --check and cargo clippy --all-targets -- -D warnings are clean.
  • cargo test --no-fail-fast passes 763 tests, 0 failures, with real Chrome (RALLY_TEST_BROWSER_REQUIRED=1).
  • cargo test --test web passes 54/54 twice at load average 10.9–12.5, in 43 s and 39 s (the failing run on main took 52 s).

🤖 Generated with Claude Code

Castor-o7 and others added 4 commits November 17, 2026 16:07
RAL-203's local/check failed in a_segfault_at_start_is_tried_once_more_
and_a_second_fails at load ~7: after the stand-in's crash at start, the
retry's real Chrome hadn't started before the run's 45 s timer fired.

- tests/web.rs: one real Chrome at a time. The 12 browser runs ran in
  parallel test threads, so several flatpak Chromes started at once. A
  process-wide lock is held only around the browser's run, not the
  viewer's setup, and a test that panicked holding it doesn't poison it.
- tests/browser/sign-in.mjs: the retry after a crash at start gets a
  fresh 45 s budget instead of what the crashed start left, and a 90 s
  cap from the script's start ends any run, so a Chrome that never
  starts holds CI for two budgets at most.

Nothing the tests prove changes: one stated retry, a second crash
fails, nothing of the browser survives. Agreed with upbeat-anole (web).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sent back by upbeat-anole (5522). The retry's timer is set only while the
first 45 s timer is pending, so the retry's deadline is always under
90 s from the start, and the cap's finish would only ever no-op. The
comment now says why a run ends within two budgets without it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Castor-o7
Castor-o7 merged commit b50e4f1 into main Nov 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant