Repository navigation
RAL-199 part 3: wake reaches the team's session by id; recipients match the stale rule - #293
Merged
Merged
Conversation
…ch the stale rule - rally wake sent to the team's name. Marshal has no nickname for a team the projects list names by its Marshal project, so that send failed. wake::wake_target now sends to the team's one live session by its id, and otherwise to the team's name, which recipient() resolves as a nickname and refuses when it's ambiguous. - recipient()'s live test matches shims::stale exactly: bound with a real pid, or waiting now. A bound row declaring pid 0 is no longer a recipient by name (gilded-canyon's nit on RAL-202). - The e2e also sends by exact session id against the throwaway daemon. With part 1 (roster) and part 2 (sending), nothing in Rally's default path reads `<shim> roster` or runs `<shim> tell` any more. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAL-199 part 3 of 3:
rally wakeend to end on Marshal, and the last shim dependency gone from the default path.Wake target:
rally wakesent to the team's name. When the projects list names a team's sessions by Marshal project rather than by nickname, Marshal has no session with that name, so the send failed.wake::wake_targetnow picks:marshal::recipientresolves as a nickname, refusing one that two live sessions hold.Stale rows are already dropped from the roster
wakereads (RAL-202), so a leftover never counts as the one session.Recipient rule:
recipient()'s test for a live session now matchesshims::staleexactly: bound with a real pid, or waiting now. A bound row that declares pid 0 is no longer a recipient by name. This was gilded-canyon's nit on RAL-202.Default path: with parts 1 and 2, nothing in Rally's default
RALLY_ROSTER_FROMreads<shim> rosteror runs<shim> tell. A shim command is used only when someone lists it.Tests:
-D warningsare clean, and the fullcargo testpasses with browser tests: 583 lib tests and 54 web tests.cargo test --test marshal -- --ignored --nocapture) also sends by exact session id to a real shim on a throwaway daemon. The message is Delivered to that session. 3 of 3 pass.🤖 Generated with Claude Code