Skip to content

RAL-199 part 3: wake reaches the team's session by id; recipients match the stale rule - #293

Merged
Castor-o7 merged 1 commit into
mainfrom
ral-199-part3
Nov 17, 2026
Merged

Castor-o7 merged 1 commit into
mainfrom
ral-199-part3

Conversation

@Castor-o7

Copy link
Copy Markdown
Owner

RAL-199 part 3 of 3: rally wake end to end on Marshal, and the last shim dependency gone from the default path.

Wake target: rally wake sent to the team's name. When the projects list names a team's sessions by Marshal project rather than by nickname, Marshal has no session with that name, so the send failed. wake::wake_target now picks:

  • the team's one live session on the roster, sent to by its session id;
  • otherwise the team's name, which marshal::recipient resolves as a nickname, refusing one that two live sessions hold.

Stale rows are already dropped from the roster wake reads (RAL-202), so a leftover never counts as the one session.

Recipient rule: recipient()'s test for a live session now matches shims::stale exactly: bound with a real pid, or waiting now. A bound row that declares pid 0 is no longer a recipient by name. This was gilded-canyon's nit on RAL-202.

Default path: with parts 1 and 2, nothing in Rally's default RALLY_ROSTER_FROM reads <shim> roster or runs <shim> tell. A shim command is used only when someone lists it.

Tests:

  • fmt and clippy -D warnings are clean, and the full cargo test passes with browser tests: 583 lib tests and 54 web tests.
  • New unit tests: the wake target (one session by id, two sessions by name, none by name) and the pid-0 recipient case.
  • The ignored e2e (cargo test --test marshal -- --ignored --nocapture) also sends by exact session id to a real shim on a throwaway daemon. The message is Delivered to that session. 3 of 3 pass.

🤖 Generated with Claude Code

…ch the stale rule

- rally wake sent to the team's name. Marshal has no nickname for a team
  the projects list names by its Marshal project, so that send failed.
  wake::wake_target now sends to the team's one live session by its id,
  and otherwise to the team's name, which recipient() resolves as a
  nickname and refuses when it's ambiguous.
- recipient()'s live test matches shims::stale exactly: bound with a
  real pid, or waiting now. A bound row declaring pid 0 is no longer a
  recipient by name (gilded-canyon's nit on RAL-202).
- The e2e also sends by exact session id against the throwaway daemon.

With part 1 (roster) and part 2 (sending), nothing in Rally's default
path reads `<shim> roster` or runs `<shim> tell` any more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Castor-o7
Castor-o7 merged commit 07cd223 into main Nov 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant