Repository navigation
RAL-199 part 2: Rally sends through Marshal's daemon as its own service session - #289
Merged
Merged
Conversation
…ce session Upstream marshal-shim 0.60.2 has no `tell`, so `rally digest` and `rally wake` couldn't send. Rally now sends itself (marshal::send): - It registers its own Session (kind "service", project "rally", cwd its state dir, a stable id per machine and command, rally-digest@<machine> or rally-wake@<machine>), waits until the daemon binds it to the connection, sends with SendMessage (never asSession), and deletes the session. The digest body opens with <rally_digest>, so it says it's from Rally's digest. - A recipient is an exact session id or one team's nickname. A name held by two sessions is refused, and service rows are never recipients. "Not on the roster" and "unreachable" let the next source be tried; a refusal or a lost answer after sending stops there. - Service rows are left out of the roster Rally shows (and counted as service_sessions), so the viewer, stalls, wake, brief and rally membership never take one for a team. - The digest finds its watchman on Marshal only through the open rally's session records (marshal::route): the designated name if it's live, otherwise the latest `rally-session --succeeds` successor, and so on, with loops refused. The row's `routed` names the chain and the record numbers, and a report-only run shows it too. This is routing only. With no chain it says the watchman can't be found on Marshal and sends nothing, and it never guesses by cwd or project. - An #[ignore]d e2e against a throwaway daemon and a real shim sends to the shim's nickname, checks the daemon stores the message from rally-digest@test, and checks no service row is left behind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Castor-o7
force-pushed
the
ral-199-part2
branch
from
November 17, 2026 20:02
9f3b1cf to
b28159c
Compare
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAL-199 part 2 of 3: direct messages through Marshal's daemon, and a digest routed to the watchman's Marshal session.
Why: upstream
marshal-shim0.60.2 has notell, sorally digestandrally wakecouldn't send anything after Muster retired.Sending (
marshal::send), as the watchman agreed:service, projectrally, cwd its state dir, and a stable id per machine and command (rally-digest@<machine>,rally-wake@<machine>).SendMessage. It never usesasSession, so it never sends as an agent.<rally_digest>, so it says it's from Rally's digest.Who a message can go to:
Service rows aren't teams: they're left out of the roster Rally shows and counted as
service_sessions. So the viewer,stalls,wake,briefand rally membership never take one for a team.Finding the watchman (
marshal::route):rally-session --succeedssuccessor, step by step, and refuses a loop.routednames the chain and its record numbers, and a report-only run shows it too, beside its own decision.Tests:
-D warningsare clean, the fullcargo testpasses (581 lib tests plus every integration suite), andcargo deny checkis ok.cargo test --test marshal -- --ignored --nocaptureagainst a throwaway ephemeral daemon and a realmarshal-shim. A send to an absent team gives NotHere. A send to the shim's nickname is Delivered, the daemon holds the message fromrally-digest@testwith the body intact, and afterwards the roster has only the shim's row andservice_sessions: 0.rally digest --report-onlyon a rewound copy of the state file showsrouted: mellow-weevil → mega-jackdaw, records [5454]. Nothing was sent.Part 3 (
wakeandstallsend to end, and nothing left on shimroster/tellby default) follows.🤖 Generated with Claude Code