Skip to content

Release SDK updates - #151

Merged
dantedanelian merged 4 commits into
mainfrom
stainless/release
Nov 18, 2026
Merged

dantedanelian merged 4 commits into
mainfrom
stainless/release

Conversation

@dantedanelian

Copy link
Copy Markdown
Contributor

67da6a4 Merge pull request #61 from CaseMark/agent/cd-2075-auto-merge-wait-for-ci
49f4086 CD-2075: Poll check runs via REST and log each poll
9e36a41 CD-2075: Keep check output when gh reports pending checks
05aa387 CD-2075: Wait for CI before auto-merging

@thurgood-bot

thurgood-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Judicial Review

Replaces native --auto merge (which merged before CI due to no required checks) with a poll-for-CI-then-merge flow for stainless bot/admin PRs. Risks are handled in code and the change reverts cleanly; verdict is approve.

  • ✅ Risks considered: Main risk (merging before CI finishes) is the explicit purpose of the change and is handled: polls both check-runs and statuses, blocks on any failure, requires total>0 with two consecutive clean polls, excludes self-job to avoid deadlock, and bounds runtime with timeout-minutes 45.
  • ✅ Revert path: Workflow-only change with no migration, data, or external state; reverting the PR restores prior --auto behavior for future runs.

Findings: 0 critical, 1 warnings, 0 info

Architecture

⚠️ WARNING in .github/workflows/stainless-auto-merge.yml:3

Trigger is only opened/reopened, so a push after the run starts would not re-run the wait on the new SHA while the in-flight run could still merge the new head.

Recommendation: Consider adding synchronize to the pull_request types or re-resolving the head SHA before the final merge step.


Legal-Grade review by Thurgood | Re-review with /review


Verdict: Approved

@thurgood-bot

thurgood-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

DB Cooper Database Review

CI-only change to .github/workflows/stainless-auto-merge.yml with no schema, migration, or query impact; no database risk and safely reversible.

  • ✅ Risks considered: No database surface: single workflow file changed, no migrations, schema, or query paths touched.
  • ✅ Revert path: Plain revert of the workflow file restores prior auto-merge behavior; no data or infra side effects.

No database risks found. Migrations and DB-impacting changes look safe.


DB review by DB Cooper | Re-run with /dbreview

@thurgood-bot thurgood-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thurgood verdict: Approved

Replaces native --auto merge (which merged before CI due to no required checks) with a poll-for-CI-then-merge flow for stainless bot/admin PRs. Risks are handled in code and the change reverts cleanly; verdict is approve.

CI-only change to .github/workflows/stainless-auto-merge.yml with no schema, migration, or query impact; no database risk and safely reversible.

  • Risks considered and a clear revert path exists

Thurgood approved this pull request.

@dantedanelian
dantedanelian merged commit 431150d into main Nov 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant