Repository navigation
fix(device-rules): validate 'action' before first read - #435
Merged
Merged
Conversation
syslog_device_rules.php read get_request_var('action') for the
ajax_hosts early-return before set_default_action() ran, so Cacti logged
"Input Validation Not Performed for 'action'". Cacti's check_all_pages CI
crawl treats that log line as a failure.
Move set_default_action() above the first action read so the request var
is registered/validated before use. No behavior change otherwise.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change that initializes action before its first read.
No open issues 🎉
What changed in this PR
Moves action initialization before the first request-variable read in the device-rules page, preventing Cacti’s input-validation warning that causes the CI page crawl to fail.
Changes:
- Calls
set_default_action()before theajax_hostsearly-return check. - Removes the later call before action dispatch, leaving the remaining logic unchanged.
| File | Description |
|---|---|
syslog_device_rules.php |
Initializes and validates action before its first read. |
Review effort: Balanced
xmacan
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syslog_device_rules.php read get_request_var('action') for the
ajax_hosts early-return before set_default_action() ran, so Cacti logged
"Input Validation Not Performed for 'action'". Cacti's check_all_pages CI
crawl treats that log line as a failure.
Move set_default_action() above the first action read so the request var
is registered/validated before use. No behavior change otherwise.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com