Repository navigation
Remove old code (restapi), clean upgrade db - #136
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
TheWitness
self-requested a review
November 2, 2026 19:28
TheWitness
previously approved these changes
Nov 2, 2026
bmfmancini
previously approved these changes
Nov 2, 2026
The restapi removal PR leaves plugin_servcheck_uninstall() dropping plugin_servcheck_restapi_method, but that table no longer belongs to the current schema (it is dropped during upgrade). ServcheckLifecycleTest now expects it absent from the uninstall table list, so CI failed. Remove the stale DROP so uninstall matches the current schema. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The restapi cleanup moved the schema migration cascade into the new includes/database.php and trimmed includes/arrays.php. Two CI gates then failed once the Pest suite ran: - patch-coverage.php flagged includes/arrays.php as a changed production file absent from Clover. It is loaded by ServcheckLegendTest but was never listed in phpunit.xml's coverage source, so add it there. - The moved servcheck_upgrade_tables() cascade counted as added lines with no coverage. Add ServcheckUpgradeTablesTest driving both the present- and absent-schema sides of the 0.3 and 0.4 cascades plus the reconciliation failure path, and make the db_column_exists/ db_table_exists/db_update_table bootstrap stubs configurable (defaults unchanged) so those branches can be exercised without a database. Patch coverage is back to 100%. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
bmfmancini
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #122
close #122