Repository navigation
Fix FlowView time range overlap filtering - #307
Merged
Merged
Conversation
somethingwithproof
force-pushed
the
fix/flowview-time-range-overlap
branch
from
November 9, 2026 01:42
5e88fe6 to
b1b86b3
Compare
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
The run statistics read map_range_params[0] and [1] as the window start and end for the shard cache lookup. Binding the overlap predicate as (end, start) turned that lookup into BETWEEN end AND start, so the cached size for default-range queries was always 0. Write the overlap test as end_time >= start AND start_time <= end so the params keep the same order as every other range type. Narrow the changelog entry: flows are still read only from the partitions inside the report window. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/flowview-time-range-overlap
branch
from
November 11, 2026 22:59
b1b86b3 to
0fa09b2
Compare
|
TheWitness
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #306
Validation