Repository navigation
feat: preserve native dtype for SCHISM outputs - #12
Merged
Merged
Conversation
This commit updates the code to keep the original data type from the SCHISM nc output files. Converting data types can be a performance bottolneck. To achieve this, we are dropping mask_and_scale. - Replace xarray mask_and_scale auto-promotion with safe float32 fill/missing value masking in read_schism_nc, open_grid, and open_ts_dataset. - Keep integer connectivity (SCHISM_hgrid_face_nodes) as integer types. - Support float32 and mixed precision in Numba kernels (_integrate_nodal, _integrate_triangle, _integrate_quad) and fix quad derivative typo. - Preserve input dtypes in SxDataArray.depth_average() and integration routines. - Update test fixtures and add unit tests validating float32 precision on single and mixed tri-quad meshes. - Remove float64 conversion workarounds from documentation notebooks.
aesgeorges
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the code to keep the original data type from the SCHISM nc output files. Converting data types can be a performance bottolneck. To achieve this, we are dropping mask_and_scale.