Repository navigation
[BI-3062] Replace simpleSearch usages for searchInternal to support >65k use cases - #578
Open
jloux-brapi wants to merge 6 commits into
Open
jloux-brapi wants to merge 6 commits into
jloux-brapi wants to merge 6 commits into
Conversation
…rt full responses - Additionally fix some broken use cases in BrAPIGermplasmDAO
jloux-brapi
commented
Nov 16, 2026
| * In this example, W should be a BrAPIGermplasmSearchRequest | ||
| * @return The full BrAPIResponse object from a completed BrAPI search request | ||
| */ | ||
| private <T extends BrAPIResponse<U>, U extends BrAPIResponseResult<V>, V, W extends BrAPISearchRequestParametersPaging> T searchInternalReturnResponse(Function<W, ApiResponse<Pair<Optional<T>, Optional<BrAPIAcceptedSearchResponse>>>> searchMethod, |
Collaborator
Author
There was a problem hiding this comment.
This method is really where to start with this PR @humsika. Everything that was changed pretty much calls this method ultimately.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-3062
searchInternalinBrAPIDAOUtilwas modified to fulfill the main requirement for simple search, was to do all of the filtering/sorting/pagination on the BrAPI side, returning the full response from BrAPI to be processed by BI instead of just the list of data. All old callers of this method now point to this new version of this method, but instead of utilizing the BrAPI response the list data is derived from the response so those callers can process the way they did before. The new implementation,searchInternalFullResponse()should satisfy the simpleSearch and old search callers expectations.sendPaging, passed through to the final search method. I found this naming pretty confusing, considering I would expect sendPaging to mean you sent paging info to the server and it responded accordingly. Instead, this boolean was being used to page through all of the data for a given search request so that bi-api could get all of the data from the brapi server in one request. Because of this, the variable has been renamed topageThru. IfpageThruis true, all of the data found in the search request is paged through and returned in full to the BrAPI server.Dependencies
Testing
Regression of the following features:
Checklist: