Skip to content

[BI-2924] Remove cache.get() dependencies in TraitDAOImpl - #572

Merged
jloux-brapi merged 4 commits into
epic/BI-2862from
feature/BI-2924
Nov 10, 2026
Merged

jloux-brapi merged 4 commits into
epic/BI-2862from
feature/BI-2924

Conversation

@jloux-brapi

@jloux-brapi jloux-brapi commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Story: BI-2924

  • Unit test was modified to remove an insert that was causing a bug with the new implementation without the cache. It seems this bug was largely ignored because of the cache's separate threading on start and update.
  • A new method to lookup traits in full directly instead of fetching all of them at once was created. This method is mainly used by the BI-BrAPI endpoint use case and the single trait use case in TraitController.

Dependencies

Testing

  • Create New Ontology terms in DeltaBreed, verify the terms are created and show up on the Ontology Page
  • Update ontology terms in DeltaBreed. This can be achieved by clicking Show Details and then clicking Edit, where if they are not already used you can edit some elements of the term. Activating and Deactivating also updates ontology. Simplify verify the changes are reflected once they are made.
  • Test the BI-BrAPI GET http://localhost:8081/v1/programs/{programDbId}/brapi/v2/variables/{traitDbId}. You will need an auth bearer token from the BrAPI sidebar tab in DeltaBreed
  • Test the BI GET http://localhost:8081/v1/programs/{programDbId}/traits/{traitDbId} endpoint. You will need an auth bearer token from the BrAPI sidebar tab in DeltaBreed

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

For one use case, I implemented a search for a single trait via exref

@humsika humsika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@humsika humsika added the on hold Review, but do not merge until removed label Nov 3, 2026
Base automatically changed from feature/BI-2923 to epic/BI-2862 November 10, 2026 19:38
@jloux-brapi
jloux-brapi merged commit d99eb91 into epic/BI-2862 Nov 10, 2026
1 check failed
@jloux-brapi
jloux-brapi deleted the feature/BI-2924 branch November 10, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature on hold Review, but do not merge until removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants