Skip to content

Make domain alignment modular - #28

Merged
AnthonyGarza124 merged 1 commit into
refactor-v2from
modular-global-alignment
Oct 26, 2026
Merged

AnthonyGarza124 merged 1 commit into
refactor-v2from
modular-global-alignment

Conversation

@ShinThomas

Copy link
Copy Markdown
Collaborator

Summary

  • Extract domain alignment into an injectable AlignmentTemplate interface.
  • Accept a query DBD and ordered ortholog DBDs, preserving duplicate occurrences and score associations.
  • Preserve existing affine-gap scoring by default; support explicit linear-gap Needleman–Wunsch configuration.
  • Preserve pipeline result ordering and identity-threshold behavior.
  • Add API documentation and regression tests.

The default implementation performs pairwise alignments. The interface allows future multiple-sequence alignment implementations; none is added here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused extraction preserves existing behavior, includes regression coverage, and has no identified blocking issues.

No open issues 🎉

What changed in this PR

Makes domain alignment injectable while preserving the pipeline’s default scoring, result ordering, and identity thresholds.

Changes:

  • Adds an alignment interface and configurable Biopython implementation.
  • Integrates ordered batch alignment while preserving duplicate domain occurrences.
  • Adds API documentation and regression tests.
File Description
tests/​v2/​test_pipeline.py Tests injection, ordering, score validation, and independent defaults.
tests/​v2/​test_alignment.py Tests identity calculation, scoring modes, and input validation.
src/​lverage/​pipeline.py Injects alignment and preserves positional score associations.
src/​lverage/​alignment.py Defines the interface and default pairwise implementation.
docs/​api/​pipeline.rst Documents injection and result ordering.
docs/​api/​index.rst Links the alignment API documentation.
docs/​api/​alignment.rst Explains the alignment contract and scoring options.

Review effort: Balanced

@AnthonyGarza124
AnthonyGarza124 merged commit 91a4783 into refactor-v2 Oct 26, 2026
2 checks passed
@AnthonyGarza124
AnthonyGarza124 deleted the modular-global-alignment branch October 26, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants