Repository navigation
Phase finales: a boss ends each phase - #54
Merged
Merged
Conversation
Ports the phase finale engine from AOneBlock: a phase file's finale: section defines a boss that seals the magic block at the end of the phase until it is killed. All default phases ship with one. ChunkBlock-specific: the boss is pulled back to the magic block if it enters a locked chunk, so the fight stays inside claimed territory. See the AOneBlock change for the full rules (player-only damage, void-respawn, retreat and mercy scaling, omen sounds, giant AI, events, island.phase-finales switch). Closes #4 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The block count is already in the next phase while a boss is pending, so the phase boss bar and action bar showed the next phase at 0 blocks. - While a boss is pending they now name it and say to hit the magic block to face it. - While the boss is alive they are hidden; the boss has its own bar. - They refresh as soon as the fight ends instead of on the next break. - Restore the missing space in the defeated message. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
dev.lone:api-itemsadder:4.0.10 no longer resolves from maven.devs.beer, which broke CI. Switch to beer.devs:itemsadder-api 4.0.17 on Maven Central and drop the matteodev repository, as AOneBlock already did. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
processPhase dereferenced a null phase when a goto pointed at a block no phase covers. Port AOneBlock's guard: log the problem and cancel the break instead of throwing. SonarCloud flagged this as a bug on the PR. Also tidy the finale code it flagged: split the finale parser into smaller methods, extract the pending-boss bar logic, drop two always-true null checks and clean up test mocks. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Ports the phase finale engine from AOneBlock (BentoBoxWorld/AOneBlock, branch
feature/phase-finales; merge that PR first so the two engines stay in step). A phase file's optionalfinale:section defines a boss that seals the magic block at the end of the phase until it is killed.Closes #4. This covers the kill-the-boss mode only; "protect the block" and timed gathering are deliberately left out for now.
How it plays
void-respawn: true(default) returns the boss to the magic block;falselets the void kill it as a win.dropsfall on every kill;first-time-commandsrun once per island.ChunkBlock-specific
The boss is pulled back to the magic block if it enters a locked chunk, so the fight stays inside claimed territory. Locked chunks are still never modified.
Details
0_plains.ymldocuments the keys. Existing servers addfinale:sections by hand.island.phase-finalesinconfig.ymlturns the feature off.PhaseFinaleStartEvent(cancellable) andPhaseFinaleEndEvent.en-UShas the four newchunkblock.finale.*messages.Testing
mvn test: 782 tests pass, including the portedFinaleListenerTest(plus a locked-chunk leash test) and parser tests over every shipped phase file.🤖 Generated with Claude Code