Skip to content

Reduce AdvancedCore shaded JAR without removing embedded transport APIs - #385

Open
BenCodez wants to merge 3 commits into
masterfrom
build/slim-shaded-jar-20261115
Open

BenCodez wants to merge 3 commits into
masterfrom
build/slim-shaded-jar-20261115

Conversation

@BenCodez

@BenCodez BenCodez commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

The non-multi-release shaded JAR includes unused versioned resources, compile-time annotations and redundant module and Maven metadata. Filter those entries while retaining the Redis/MQTT/HTTP APIs, runtime libraries, service descriptors and licenses. Maven Shade minimization remains disabled. Consumers compiling directly against the excluded annotation types must declare their separate annotation dependency.

The JAR dropped from 6,991,512 to 6,673,681 bytes, saving 317,831 bytes (4.55%). Hosted Maven validated head 1ef438a2 with 1,723 unit tests passed and two packaged-artifact checks passed. There were zero failures or errors. Build log

The coordinated VotingPlugin build with this branch and SimpleAPI #124 also passed; live-server acceptance remains separate. Coordinated CI

Summary by CodeRabbit

  • Improvements
    • The packaged artifact excludes unnecessary versioned code, module metadata, and dependency documentation while retaining required runtime components.
  • Documentation
    • Added details about packaged contents, size filtering, and artifact validation, including the limits of automated packaging tests.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The shaded JAR configuration now excludes selected multi-release, module, annotation, and Maven metadata entries. Packaging tests check required classes and excluded entries. Documentation describes the filtering rules and packaging test limits.

Changes: Shaded JAR Filtering

Layer / File(s) Summary
Configure and verify shaded JAR contents
AdvancedCore/pom.xml, AdvancedCore/src/test/java/com/bencodez/advancedcore/tests/packaging/PackagedArtifactTest.java, docs/jar-packaging.md
The Shade Plugin excludes selected multi-release, module, annotation, and Maven metadata entries. The packaging test checks required classes and filtered content. The documentation describes the filtering rules and test limits.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to 1ef43

This change trims metadata and compile-only annotation classes from the shaded JAR while keeping the embedded transport APIs. No concrete problem was found, so merge risk is minimal. Downstream validation is still pending in CI.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the main change: the AdvancedCore shaded JAR is reduced in size while embedded transport APIs (Redis, MQTT, HTTP TLS) are kept. The raw summary confirms the shade plugin exclusions, t…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title states the main change: the AdvancedCore shaded JAR is reduced in size while embedded transport APIs (Redis, MQTT, HTTP TLS) are kept. The raw summary confirms the shade plugin exclusions, the packaged-artifact tests, and the docs describe that trade-off. The title is specific and matches the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

OSV Scanner (2.7.0)

AdvancedCore/pom.xml

OSV Scanner exited with code 127; dependency analysis is incomplete

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3e918c67-3f94-4fed-b987-efc06e886ab6
Commits

Reviewing files that changed from the base of the PR and between 5d14329 and 1ef438a.

Files selected for processing: 3

  • AdvancedCore/pom.xml
  • AdvancedCore/src/test/java/com/bencodez/advancedcore/tests/packaging/PackagedArtifactTest.java
  • docs/jar-packaging.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 4

  • GitHub Check: CodeRabbit
  • GitHub Check: build
  • GitHub Check: Analyze (java-kotlin)
  • GitHub Check: Analyze (actions)
Additional context used

Code guidelines: 1

AGENTS.md — auto-discovered
Path-based instructions: 1

Source excerpt: All test classes and test-only helpers must live under `com.bencodez.advancedcore.tests` or its subpackages, with matching directories under `AdvancedCore/src/test/java`.

CodeRabbit inference engine (AGENTS.md)

Files:

  • AdvancedCore/src/test/java/com/bencodez/advancedcore/tests/packaging/PackagedArtifactTest.java
Learnings: 1

Common learnings

Learnt from: CR
Repo: BenCodez/AdvancedCore

Timestamp: 2026-11-15T23:02:07.279Z
Learning: Source excerpt:
# AdvancedCore code review

## 3. Trace changed behavior and its contracts

### Security, packaging, and test evidence

- For build/dependency changes, inspect Java release, annotation processors,
  dependency scopes, shading/relocation/minimization, reflection/service loading,
  packaged resources, and optional-dependency/classpath compatibility.

@BenCodez
BenCodez marked this pull request as ready for review November 15, 2026 23:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T23:15:27.973098Z 1ef438a Draft marked ready
🔒 Security Review ✅ Completed 2026-11-15T23:17:08.606897Z 1ef438a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant